All of lore.kernel.org
 help / color / mirror / Atom feed
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: imx-sdma: remove the unused completion
Date: Mon, 19 Aug 2013 14:33:25 +0800	[thread overview]
Message-ID: <5211BC35.5080507@freescale.com> (raw)
In-Reply-To: <1373010655-3800-1-git-send-email-b32955@freescale.com>

? 2013?07?05? 15:50, Huang Shijie ??:
> After the patch: "2ccaef0 dma: imx-sdma: make channel0 operations atomic",
> the "done" completion is not used any more.
>
> Just remove it.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
>  drivers/dma/imx-sdma.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 1e44b8c..2c02a9d 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -243,7 +243,6 @@ struct sdma_engine;
>   * @event_id1		for channels that use 2 events
>   * @word_size		peripheral access size
>   * @buf_tail		ID of the buffer that was processed
> - * @done		channel completion
>   * @num_bd		max NUM_BD. number of descriptors currently handling
>   */
>  struct sdma_channel {
> @@ -255,7 +254,6 @@ struct sdma_channel {
>  	unsigned int			event_id1;
>  	enum dma_slave_buswidth		word_size;
>  	unsigned int			buf_tail;
> -	struct completion		done;
>  	unsigned int			num_bd;
>  	struct sdma_buffer_descriptor	*bd;
>  	dma_addr_t			bd_phys;
> @@ -547,8 +545,6 @@ static void sdma_tasklet(unsigned long data)
>  {
>  	struct sdma_channel *sdmac = (struct sdma_channel *) data;
>  
> -	complete(&sdmac->done);
> -
>  	if (sdmac->flags & IMX_DMA_SG_LOOP)
>  		sdma_handle_channel_loop(sdmac);
>  	else
> @@ -812,9 +808,6 @@ static int sdma_request_channel(struct sdma_channel *sdmac)
>  	sdma->channel_control[channel].current_bd_ptr = sdmac->bd_phys;
>  
>  	sdma_set_channel_priority(sdmac, MXC_SDMA_DEFAULT_PRIORITY);
> -
> -	init_completion(&sdmac->done);
> -
>  	return 0;
>  out:
>  
Hi Vinod:
Could you merge this patch?

thanks
Huang Shijie

  parent reply	other threads:[~2013-08-19  6:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05  7:50 [PATCH] dma: imx-sdma: remove the unused completion Huang Shijie
2013-07-06  5:13 ` Shawn Guo
2013-08-19  6:33 ` Huang Shijie [this message]
2013-08-19  8:47 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5211BC35.5080507@freescale.com \
    --to=b32955@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.