diff for duplicates of <5211EFC7.9090800@arm.com> diff --git a/a/1.txt b/N1/1.txt index 8ba5a9d..8eff387 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,30 +8,30 @@ On 16/08/13 23:13, Benjamin Herrenschmidt wrote: >> + int ac, prop_len, tid; >> + u64 hwid; >> + ->> + ac = of_n_addr_cells(cpun); ->> + cell = of_get_property(cpun, prop_name, &prop_len); +>> + ac =3D of_n_addr_cells(cpun); +>> + cell =3D of_get_property(cpun, prop_name, &prop_len); >> + if (!cell) >> + return false; ->> + prop_len /= sizeof(*cell); ->> + for (tid = 0; tid < prop_len; tid++) { ->> + hwid = of_read_number(cell, ac); +>> + prop_len /=3D sizeof(*cell); +>> + for (tid =3D 0; tid < prop_len; tid++) { +>> + hwid =3D of_read_number(cell, ac); >> + if (arch_match_cpu_phys_id(cpu, hwid)) { >> + if (thread) ->> + *thread = tid; +>> + *thread =3D tid; >> + return true; >> + } ->> + cell += ac; +>> + cell +=3D ac; >> + } >> + return false; >> +} -> +>=20 > The only problem I can see here is if "ac" is not 1, that will not work > for the ibm,ppc-interrupt-server#s case. IE. The latter is always 1 cell > per entry, only "reg" depends on #address-cells. -> +>=20 > However that's only a theorical problem since on ppc #address-cells of > /cpus is always 1... -> +>=20 Ok agreed, but I assume in future if thread ids need 2 ac, it would use standard 'reg' instead of 'ibm,ppc-interrupt-server#' property. diff --git a/a/content_digest b/N1/content_digest index e241127..9da293d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,17 +6,17 @@ "Subject\0Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures\0" "Date\0Mon, 19 Aug 2013 11:13:27 +0100\0" "To\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0" - "Cc\0Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>" - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - linux-pm@vger.kernel.org <linux-pm@vger.kernel.org> + "Cc\0Jonas Bonn <jonas@southpole.se>" devicetree@vger.kernel.org <devicetree@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - Jonas Bonn <jonas@southpole.se> Michal Simek <monstr@monstr.eu> + linux-pm@vger.kernel.org <linux-pm@vger.kernel.org> + Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + rob.herring@calxeda.com <rob.herring@calxeda.com> Rafael J. Wysocki <rjw@sisk.pl> grant.likely@linaro.org <grant.likely@linaro.org> - " rob.herring@calxeda.com <rob.herring@calxeda.com>\0" + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" "On 16/08/13 23:13, Benjamin Herrenschmidt wrote:\n" @@ -29,30 +29,30 @@ ">> + int ac, prop_len, tid;\n" ">> + u64 hwid;\n" ">> +\n" - ">> + ac = of_n_addr_cells(cpun);\n" - ">> + cell = of_get_property(cpun, prop_name, &prop_len);\n" + ">> + ac =3D of_n_addr_cells(cpun);\n" + ">> + cell =3D of_get_property(cpun, prop_name, &prop_len);\n" ">> + if (!cell)\n" ">> + return false;\n" - ">> + prop_len /= sizeof(*cell);\n" - ">> + for (tid = 0; tid < prop_len; tid++) {\n" - ">> + hwid = of_read_number(cell, ac);\n" + ">> + prop_len /=3D sizeof(*cell);\n" + ">> + for (tid =3D 0; tid < prop_len; tid++) {\n" + ">> + hwid =3D of_read_number(cell, ac);\n" ">> + if (arch_match_cpu_phys_id(cpu, hwid)) {\n" ">> + if (thread)\n" - ">> + *thread = tid;\n" + ">> + *thread =3D tid;\n" ">> + return true;\n" ">> + }\n" - ">> + cell += ac;\n" + ">> + cell +=3D ac;\n" ">> + }\n" ">> + return false;\n" ">> +}\n" - "> \n" + ">=20\n" "> The only problem I can see here is if \"ac\" is not 1, that will not work\n" "> for the ibm,ppc-interrupt-server#s case. IE. The latter is always 1 cell\n" "> per entry, only \"reg\" depends on #address-cells.\n" - "> \n" + ">=20\n" "> However that's only a theorical problem since on ppc #address-cells of\n" "> /cpus is always 1...\n" - "> \n" + ">=20\n" "Ok agreed, but I assume in future if thread ids need 2 ac, it would use\n" "standard 'reg' instead of 'ibm,ppc-interrupt-server#' property.\n" "\n" @@ -62,4 +62,4 @@ "Regards,\n" Sudeep -fbe6ec4593e8204ec2f4a8cb98acc9a6d37a1148a4350235a1dd69f17ea94ee7 +6082373c3ec883ba953715cbba974858964342aa0894b3c7122b461e30b63e53
diff --git a/a/content_digest b/N2/content_digest index e241127..9eb39a9 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,21 +2,10 @@ "ref\01376674791-28244-1-git-send-email-Sudeep.KarkadaNagesha@arm.com\0" "ref\01376674791-28244-2-git-send-email-Sudeep.KarkadaNagesha@arm.com\0" "ref\01376691186.25016.4.camel@pasglop\0" - "From\0Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>\0" - "Subject\0Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures\0" + "From\0Sudeep.KarkadaNagesha@arm.com (Sudeep KarkadaNagesha)\0" + "Subject\0[RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures\0" "Date\0Mon, 19 Aug 2013 11:13:27 +0100\0" - "To\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0" - "Cc\0Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>" - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - linux-pm@vger.kernel.org <linux-pm@vger.kernel.org> - devicetree@vger.kernel.org <devicetree@vger.kernel.org> - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - Jonas Bonn <jonas@southpole.se> - Michal Simek <monstr@monstr.eu> - Rafael J. Wysocki <rjw@sisk.pl> - grant.likely@linaro.org <grant.likely@linaro.org> - " rob.herring@calxeda.com <rob.herring@calxeda.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 16/08/13 23:13, Benjamin Herrenschmidt wrote:\n" @@ -62,4 +51,4 @@ "Regards,\n" Sudeep -fbe6ec4593e8204ec2f4a8cb98acc9a6d37a1148a4350235a1dd69f17ea94ee7 +28af30ddef38ffbf1b4aada96c21bc98a9cbcf3116182bd54fc8898e04b40f3b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.