All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <juhosg@openwrt.org>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 2/6] rt2x00: rt2800lib: introduce RT2800_HAS_HIGH_SHARED_MEM flag
Date: Mon, 19 Aug 2013 13:19:41 +0200	[thread overview]
Message-ID: <5211FF4D.8080601@openwrt.org> (raw)
In-Reply-To: <1376762167-24583-3-git-send-email-juhosg@openwrt.org>

2013.08.17. 19:56 keltezéssel, Gabor Juhos írta:
> Some chipsets have more than 16KB of shared memory.
> Introduce a new rt2800 specific flag to indicate that
> and add a helper function which helps to check the
> presence of the new flag.
> 
> Also enable the new flag for the RT3593 chipset which
> has 24KB of shared memory. The flag can also be used
> for other chipsets, but none of those has been tested
> yet.
> 
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
> ---
>  drivers/net/wireless/rt2x00/rt2800lib.c |    9 +++++++++
>  drivers/net/wireless/rt2x00/rt2800lib.h |   13 +++++++++++++
>  2 files changed, 22 insertions(+)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index aa6b6b0..2d409e0 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -7697,6 +7697,7 @@ static int rt2800_probe_rt(struct rt2x00_dev *rt2x00dev)
>  
>  int rt2800_probe_hw(struct rt2x00_dev *rt2x00dev)
>  {
> +	struct rt2800_drv_data *drv_data = rt2x00dev->drv_data;
>  	int retval;
>  	u32 reg;
>  
> @@ -7704,6 +7705,14 @@ int rt2800_probe_hw(struct rt2x00_dev *rt2x00dev)
>  	if (retval)
>  		return retval;
>  
> +	switch (rt2x00dev->chip.rt) {
> +	case RT3071:
> +	case RT3593:
> +	case RT5592:
> +		__set_bit(RT2800_HAS_HIGH_SHARED_MEM, &drv_data->rt2800_flags);
> +		break;

Erm, this contradicts with the changelog. I will remove 3071 and 5592 and will
send an updated set.

-Gabor

  reply	other threads:[~2013-08-19 11:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17 17:56 [PATCH 0/6] rt2x00: fix beaconing on RT3593 Gabor Juhos
2013-08-17 17:56 ` [PATCH 1/6] rt2x00: rt2800lib: move rt2800_drv_data declaration into rt2800lib.h Gabor Juhos
2013-08-17 17:56 ` [PATCH 2/6] rt2x00: rt2800lib: introduce RT2800_HAS_HIGH_SHARED_MEM flag Gabor Juhos
2013-08-19 11:19   ` Gabor Juhos [this message]
2013-08-17 17:56 ` [PATCH 3/6] rt2x00: rt2800: serialize shared memory access Gabor Juhos
2013-08-17 17:56 ` [PATCH 4/6] rt2x00: rt2800lib: add rt2800_hw_beacon_base helper Gabor Juhos
2013-08-17 17:56 ` [PATCH 5/6] rt2x00: rt2800lib: don't hardcode beacon offsets Gabor Juhos
2013-08-17 17:56 ` [PATCH 6/6] rt2x00: rt2800lib: fix beacon generation on RT3593 Gabor Juhos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5211FF4D.8080601@openwrt.org \
    --to=juhosg@openwrt.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.