From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBOnR-0006R5-Ts
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 08:43:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBOnK-0006yL-AQ
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 08:42:57 -0400
Message-ID: <521212C6.3070704@suse.de>
Date: Mon, 19 Aug 2013 14:42:46 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1376915356-31011-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	<1376915356-31011-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <1376915356-31011-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/3] target-ppc: Update slb array with
 correct index values.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>=20
> Without this, a value of rb=3D0 and rs=3D0, results in replacing the 0t=
h

"... rs=3D0 results in ..."

> index. This can be observed when using gdb remote debugging support.
>=20
> (gdb) x/10i do_fork
>    0xc000000000085330 <do_fork>:        Cannot access memory at address=
 0xc000000000085330
> (gdb)
>=20
> This is because when we do the slb sync via kvm_cpu_synchronize_state,
> we overwrite the slb entry (0th entry) for 0xc00000000008533

Is there a trailing 0 missing here?

>=20
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  target-ppc/kvm.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>=20
> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> index 30a870e..5d4e613 100644
> --- a/target-ppc/kvm.c
> +++ b/target-ppc/kvm.c
> @@ -1034,8 +1034,18 @@ int kvm_arch_get_registers(CPUState *cs)
>          /* Sync SLB */
>  #ifdef TARGET_PPC64
>          for (i =3D 0; i < 64; i++) {
> -            ppc_store_slb(env, sregs.u.s.ppc64.slb[i].slbe,
> -                               sregs.u.s.ppc64.slb[i].slbv);
> +            target_ulong rb  =3D sregs.u.s.ppc64.slb[i].slbe;

Double space.

> +            /*
> +             * KVM_GET_SREGS doesn't retun slb entry with slot informa=
tion
> +             * same as index. So don't depend on the slot information =
in
> +             * the returned value.
> +             */
> +            rb &=3D ~0xfff;
> +            /*
> +             * use the array index as the slot
> +             */
> +            rb |=3D i;
> +            ppc_store_slb(env, rb, sregs.u.s.ppc64.slb[i].slbv);
>          }
>  #endif
> =20

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg