From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBPrD-00026j-5r
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:51:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBPr6-0007Lt-Oz
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:50:55 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34905 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VBPr6-0007Lj-Hl
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 09:50:48 -0400
Message-ID: <521222B5.2050202@suse.de>
Date: Mon, 19 Aug 2013 15:50:45 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1609927484.62705.1376639964118.open-xchange@email.1und1.de>
	<CAFEAcA8oFc6r8h4ibfCJNWwa==gzA+DA-h4qAw+mk3HFvMoGwA@mail.gmail.com>
In-Reply-To: <CAFEAcA8oFc6r8h4ibfCJNWwa==gzA+DA-h4qAw+mk3HFvMoGwA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN
	qmp-commands.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Erik Rull <erik.rull@rdsoftware.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@gmail.com>

Am 16.08.2013 15:21, schrieb Peter Maydell:
> On 16 August 2013 08:59, Erik Rull <erik.rull@rdsoftware.de> wrote:
>> Hi all,
>>
>> when using the released qemu-1.6.0.tar.bz2, I get the following error =
message:
>>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>>     except QAPISchemaError as e:
>>                             ^
>> SyntaxError: invalid syntax
>> make: *** [qmp-commands.h] Error 1
>=20
> My guess is that your python is older than 2.6; I think
> the "except Foo as e" syntax is new in 2.6. We probably
> missed this because most people use a newer Python than
> 2.6, but configure's check only requires 2.4 or better.
>=20
> We should probably update the scripts to not use overly
> new features (or alternatively decide that 2.6 is our new
> minimum -- what do RHEL5 and our other oldest-supported
> distros ship?)

I vaguely remember running into such problems before... possibly on
Solaris. We compiled a list of Python versions and I think settled for
2.4 based on some old RHEL, too. CC'ing Stefan.

git-blame points to:
http://repo.or.cz/w/qemu.git/commit/e120d449e1b39ec508c297b963ce452628dd3=
7c3?f=3Dconfigure

Andreas

>=20
> For this specific case I think it needs to change to
>      except QAPISchemaError, e:
>=20
> thanks
> -- PMM
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg