From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v4 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev() Date: Mon, 19 Aug 2013 18:23:37 +0400 Message-ID: <52122A69.6080000@cogentembedded.com> References: <1376908667-14974-1-git-send-email-rogerq@ti.com> <1376908667-14974-5-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f182.google.com ([209.85.217.182]:42425 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833Ab3HSOXj (ORCPT ); Mon, 19 Aug 2013 10:23:39 -0400 Received: by mail-lb0-f182.google.com with SMTP id v20so3005356lbc.13 for ; Mon, 19 Aug 2013 07:23:38 -0700 (PDT) In-Reply-To: <1376908667-14974-5-git-send-email-rogerq@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Roger Quadros Cc: balbi@ti.com, bcousson@baylibre.com, tony@atomide.com, george.cherian@ti.com, kishon@ti.com, bigeasy@linutronix.de, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Hello. On 08/19/2013 02:37 PM, Roger Quadros wrote: > omap_get_control_dev() is being deprecated as it doesn't support > multiple instances. As control device is present only from OMAP4 > onwards which supports DT only, we use phandles to get the > reference to the control device. > As we don't support non-DT boot, we just bail out on probe > if device node is not present. > Signed-off-by: Roger Quadros > --- > drivers/usb/phy/phy-omap-usb3.c | 22 ++++++++++++++++++---- > 1 files changed, 18 insertions(+), 4 deletions(-) > diff --git a/drivers/usb/phy/phy-omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c > index 4a7f27c..981313e 100644 > --- a/drivers/usb/phy/phy-omap-usb3.c > +++ b/drivers/usb/phy/phy-omap-usb3.c [...] > @@ -198,6 +199,12 @@ static int omap_usb3_probe(struct platform_device *pdev) > { > struct omap_usb *phy; > struct resource *res; > + struct device_node *node = pdev->dev.of_node; > + struct device_node *control_node; > + struct platform_device *control_pdev; Could you align the variable names with the above 2 variables? Either that, or remove the alignment of those two. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Mon, 19 Aug 2013 18:23:37 +0400 Subject: [PATCH v4 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev() In-Reply-To: <1376908667-14974-5-git-send-email-rogerq@ti.com> References: <1376908667-14974-1-git-send-email-rogerq@ti.com> <1376908667-14974-5-git-send-email-rogerq@ti.com> Message-ID: <52122A69.6080000@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 08/19/2013 02:37 PM, Roger Quadros wrote: > omap_get_control_dev() is being deprecated as it doesn't support > multiple instances. As control device is present only from OMAP4 > onwards which supports DT only, we use phandles to get the > reference to the control device. > As we don't support non-DT boot, we just bail out on probe > if device node is not present. > Signed-off-by: Roger Quadros > --- > drivers/usb/phy/phy-omap-usb3.c | 22 ++++++++++++++++++---- > 1 files changed, 18 insertions(+), 4 deletions(-) > diff --git a/drivers/usb/phy/phy-omap-usb3.c b/drivers/usb/phy/phy-omap-usb3.c > index 4a7f27c..981313e 100644 > --- a/drivers/usb/phy/phy-omap-usb3.c > +++ b/drivers/usb/phy/phy-omap-usb3.c [...] > @@ -198,6 +199,12 @@ static int omap_usb3_probe(struct platform_device *pdev) > { > struct omap_usb *phy; > struct resource *res; > + struct device_node *node = pdev->dev.of_node; > + struct device_node *control_node; > + struct platform_device *control_pdev; Could you align the variable names with the above 2 variables? Either that, or remove the alignment of those two. WBR, Sergei