From: Stephen Warren <swarren@wwwdotorg.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-usb@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
sergei.shtylyov@cogentembedded.com,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
devicetree@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics
Date: Mon, 19 Aug 2013 09:50:02 -0600 [thread overview]
Message-ID: <52123EAA.10507@wwwdotorg.org> (raw)
In-Reply-To: <520F41F0.8080707@linutronix.de>
On 08/17/2013 03:27 AM, Sebastian Andrzej Siewior wrote:
> On 08/17/2013 12:52 AM, Stephen Warren wrote:
>> On 08/15/2013 07:13 AM, Sebastian Andrzej Siewior wrote:
>>> This prefix is currently used for the musb driver.
>>
>>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>>
>>> +mg Mentor Graphics
>>
>> It's slightly short; I would have preferred "mentor" I think. but I
>> guess it's fine.
>>
>> I see that both values are already used though:
>>
>>> arch/arm/boot/dts/am33xx.dtsi:375: compatible = "mg,musbmhdrc";
>>> arch/arm/boot/dts/am33xx.dtsi:430: compatible = "mg,musbmhdrc";
>>
>>> arch/arm/boot/dts/dbx5x0.dtsi:181: "mentor,musb";
>>
>> Should both be documented? Should the bindings for those devices be
>> unified on one vendor prefix, with the old one perhaps still documented
>> as deprecated depending on how long it's been around?
>
> I wasn't aware of the dbx5x0 mentor,usb binding. As far as the am33xx
> is concerned, it has been prepared for the next merge window and can be
> changed.
OK, changing it to mentor, seems simplest and most convenient then.
> However the mentor,usb binding isn't documented either.
Presumably you can just adjust this patch to document it.
next parent reply other threads:[~2013-08-19 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1376572427-17689-1-git-send-email-bigeasy@linutronix.de>
[not found] ` <520EAD1D.2090802@wwwdotorg.org>
[not found] ` <520F41F0.8080707@linutronix.de>
2013-08-19 15:50 ` Stephen Warren [this message]
2013-08-19 17:14 ` [PATCH 1/3] of: add vendor prefix for Mentor Graphics Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52123EAA.10507@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=lee.jones@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.