From: Stephen Warren <swarren@wwwdotorg.org>
To: Sherman Yin <syin@broadcom.com>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
matt.porter@linaro.org, csd@broadcom.com, mmayer@broadcom.com,
james.hogan@imgtec.com
Subject: Re: [PATCH] pinctrl: Pass all configs to driver on pin_config_set()
Date: Mon, 19 Aug 2013 13:12:06 -0600 [thread overview]
Message-ID: <52126E06.1040108@wwwdotorg.org> (raw)
In-Reply-To: <1376606573-15093-1-git-send-email-syin@broadcom.com>
On 08/15/2013 04:42 PM, Sherman Yin wrote:
> When setting pin configuration in the pinctrl framework, pin_config_set() or
> pin_config_group_set() is called in a loop to set one configuration at a time
> for the specified pin or group.
>
> This patch 1) removes the loop and 2) changes the API to pass the whole pin
> config array to the driver. It is now up to the driver to loop through the
> configs. This allows the driver to potentially combine configs and reduce the
> number of writes to pin config registers.
>
> Signed-off-by: Sherman Yin <syin@broadcom.com>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> Change-Id: I99cbfa2ae7b774456eb71edb276711b1ddcd42c8
That tag shouldn't be included in upstream patches.
> drivers/pinctrl/pinconf.c | 42 ++++----
> drivers/pinctrl/pinctrl-tegra.c | 69 ++++++------
> include/linux/pinctrl/pinconf.h | 6 +-
Those files, Reviewed-by: Stephen Warren <swarren@nvidia.com>
On Tegra (Tegra114 Dalmore board, on top of next-20130816),
Tested-by: Stephen Warren <nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: Pass all configs to driver on pin_config_set()
Date: Mon, 19 Aug 2013 13:12:06 -0600 [thread overview]
Message-ID: <52126E06.1040108@wwwdotorg.org> (raw)
In-Reply-To: <1376606573-15093-1-git-send-email-syin@broadcom.com>
On 08/15/2013 04:42 PM, Sherman Yin wrote:
> When setting pin configuration in the pinctrl framework, pin_config_set() or
> pin_config_group_set() is called in a loop to set one configuration at a time
> for the specified pin or group.
>
> This patch 1) removes the loop and 2) changes the API to pass the whole pin
> config array to the driver. It is now up to the driver to loop through the
> configs. This allows the driver to potentially combine configs and reduce the
> number of writes to pin config registers.
>
> Signed-off-by: Sherman Yin <syin@broadcom.com>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> Change-Id: I99cbfa2ae7b774456eb71edb276711b1ddcd42c8
That tag shouldn't be included in upstream patches.
> drivers/pinctrl/pinconf.c | 42 ++++----
> drivers/pinctrl/pinctrl-tegra.c | 69 ++++++------
> include/linux/pinctrl/pinconf.h | 6 +-
Those files, Reviewed-by: Stephen Warren <swarren@nvidia.com>
On Tegra (Tegra114 Dalmore board, on top of next-20130816),
Tested-by: Stephen Warren <nvidia.com>
next prev parent reply other threads:[~2013-08-19 19:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 22:42 [PATCH] pinctrl: Pass all configs to driver on pin_config_set() Sherman Yin
2013-08-15 22:42 ` Sherman Yin
2013-08-19 19:12 ` Stephen Warren [this message]
2013-08-19 19:12 ` Stephen Warren
2013-08-21 22:14 ` Linus Walleij
2013-08-21 22:14 ` Linus Walleij
2013-08-22 0:43 ` Sherman Yin
2013-08-22 0:43 ` Sherman Yin
2013-08-22 1:14 ` [PATCH v2] " syin
2013-08-22 1:14 ` syin at broadcom.com
2013-08-22 1:18 ` Sherman Yin
2013-08-22 1:18 ` Sherman Yin
2013-08-23 17:42 ` Linus Walleij
2013-08-23 17:42 ` Linus Walleij
2013-08-26 2:46 ` Sherman Yin
2013-08-26 2:46 ` Sherman Yin
2013-08-26 2:41 ` [PATCH v3] " Sherman Yin
2013-08-27 8:56 ` Laurent Pinchart
2013-08-27 18:22 ` Sherman Yin
[not found] ` <1377484899-4918-1-git-send-email-syin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-08-28 11:44 ` Linus Walleij
2013-08-27 18:32 ` [PATCH v4] " Sherman Yin
2013-08-27 18:32 ` Sherman Yin
2013-08-27 23:14 ` Laurent Pinchart
2013-08-27 23:14 ` Laurent Pinchart
2013-08-27 23:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52126E06.1040108@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=csd@broadcom.com \
--cc=james.hogan@imgtec.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.porter@linaro.org \
--cc=mmayer@broadcom.com \
--cc=syin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.