From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adjd_s311: Cleanup unused #defines
Date: Mon, 19 Aug 2013 20:12:36 +0100 [thread overview]
Message-ID: <52126E24.9070104@kernel.org> (raw)
In-Reply-To: <1376830753-2430-2-git-send-email-pmeerw@pmeerw.net>
On 08/18/13 13:59, Peter Meerwald wrote:
> using word reads, no need for HI/LO register #defines
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Applied to the togreg branch of iio.git.
Thanks Peter
> ---
> drivers/iio/light/adjd_s311.c | 28 ++++++++++------------------
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/iio/light/adjd_s311.c b/drivers/iio/light/adjd_s311.c
> index c4b730d..23cff79 100644
> --- a/drivers/iio/light/adjd_s311.c
> +++ b/drivers/iio/light/adjd_s311.c
> @@ -37,22 +37,14 @@
> #define ADJD_S311_CAP_GREEN 0x07
> #define ADJD_S311_CAP_BLUE 0x08
> #define ADJD_S311_CAP_CLEAR 0x09
> -#define ADJD_S311_INT_RED_LO 0x0a
> -#define ADJD_S311_INT_RED_HI 0x0b
> -#define ADJD_S311_INT_GREEN_LO 0x0c
> -#define ADJD_S311_INT_GREEN_HI 0x0d
> -#define ADJD_S311_INT_BLUE_LO 0x0e
> -#define ADJD_S311_INT_BLUE_HI 0x0f
> -#define ADJD_S311_INT_CLEAR_LO 0x10
> -#define ADJD_S311_INT_CLEAR_HI 0x11
> -#define ADJD_S311_DATA_RED_LO 0x40
> -#define ADJD_S311_DATA_RED_HI 0x41
> -#define ADJD_S311_DATA_GREEN_LO 0x42
> -#define ADJD_S311_DATA_GREEN_HI 0x43
> -#define ADJD_S311_DATA_BLUE_LO 0x44
> -#define ADJD_S311_DATA_BLUE_HI 0x45
> -#define ADJD_S311_DATA_CLEAR_LO 0x46
> -#define ADJD_S311_DATA_CLEAR_HI 0x47
> +#define ADJD_S311_INT_RED 0x0a
> +#define ADJD_S311_INT_GREEN 0x0c
> +#define ADJD_S311_INT_BLUE 0x0e
> +#define ADJD_S311_INT_CLEAR 0x10
> +#define ADJD_S311_DATA_RED 0x40
> +#define ADJD_S311_DATA_GREEN 0x42
> +#define ADJD_S311_DATA_BLUE 0x44
> +#define ADJD_S311_DATA_CLEAR 0x46
> #define ADJD_S311_OFFSET_RED 0x48
> #define ADJD_S311_OFFSET_GREEN 0x49
> #define ADJD_S311_OFFSET_BLUE 0x4a
> @@ -73,8 +65,8 @@ enum adjd_s311_channel_idx {
> IDX_RED, IDX_GREEN, IDX_BLUE, IDX_CLEAR
> };
>
> -#define ADJD_S311_DATA_REG(chan) (ADJD_S311_DATA_RED_LO + (chan) * 2)
> -#define ADJD_S311_INT_REG(chan) (ADJD_S311_INT_RED_LO + (chan) * 2)
> +#define ADJD_S311_DATA_REG(chan) (ADJD_S311_DATA_RED + (chan) * 2)
> +#define ADJD_S311_INT_REG(chan) (ADJD_S311_INT_RED + (chan) * 2)
> #define ADJD_S311_CAP_REG(chan) (ADJD_S311_CAP_RED + (chan))
>
> static int adjd_s311_req_data(struct iio_dev *indio_dev)
>
next prev parent reply other threads:[~2013-08-19 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 12:59 [PATCH 1/2] iio: adjd_s311: Fix non-scan mode data read Peter Meerwald
2013-08-18 12:59 ` [PATCH 2/2] iio: adjd_s311: Cleanup unused #defines Peter Meerwald
2013-08-19 19:12 ` Jonathan Cameron [this message]
2013-08-19 18:54 ` [PATCH 1/2] iio: adjd_s311: Fix non-scan mode data read Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52126E24.9070104@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.