From: Paolo Bonzini <pbonzini@redhat.com>
To: Mike Day <ncmike@ncultra.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object oriented casts with runtime checking semantics.
Date: Mon, 19 Aug 2013 22:00:36 +0200 [thread overview]
Message-ID: <52127964.3070102@redhat.com> (raw)
In-Reply-To: <87d2p9ik4z.fsf@pixel.localdomain>
Il 19/08/2013 20:57, Mike Day ha scritto:
>>> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>>> >> index ebcb52a..46d8c27 100644
>>> >> --- a/hw/misc/ivshmem.c
>>> >> +++ b/hw/misc/ivshmem.c
>>> >> @@ -789,7 +789,7 @@ static void pci_ivshmem_uninit(PCIDevice *dev)
>>> >>
>>> >> static void pci_ivshmem_instance_finalize(Object *obj)
>>> >> {
>>> >> - IVShmemState *s = IVSHMEM(dev);
>>> >> + IVShmemState *s = IVSHMEM(obj);
>> >
>> > This should have been a flat-out compiler error, right?
> Yes, correct, but Paolo hasn't previously submitted this specific change
> code afaik.
>
Yes, it's just a conflict resolution pasto.
I squashed the changes into the branch.
Paolo
next prev parent reply other threads:[~2013-08-19 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 18:33 [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object oriented casts with runtime checking semantics Mike Day
2013-08-19 18:47 ` Peter Maydell
2013-08-19 18:57 ` Mike Day
2013-08-19 20:00 ` Paolo Bonzini [this message]
2013-08-19 19:25 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52127964.3070102@redhat.com \
--to=pbonzini@redhat.com \
--cc=ncmike@ncultra.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.