From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from avon.wwwdotorg.org ([2001:470:1f0f:bd7::2]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VBWiS-0001b4-PB for linux-mtd@lists.infradead.org; Mon, 19 Aug 2013 21:10:21 +0000 Message-ID: <521289A3.5040705@wwwdotorg.org> Date: Mon, 19 Aug 2013 15:09:55 -0600 From: Stephen Warren MIME-Version: 1.0 To: Alexander Shiyan Subject: Re: [PATCH v4 1/4] mtd: nand: gpio: Add DT property to automatically determine bus width References: <1376637583-12485-1-git-send-email-shc_work@mail.ru> In-Reply-To: <1376637583-12485-1-git-send-email-shc_work@mail.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Mark Rutland , devicetree@vger.kernel.org, Ian Campbell , Pawel Moll , Artem Bityutskiy , Rob Herring , linux-mtd@lists.infradead.org, Grant Likely , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/16/2013 01:19 AM, Alexander Shiyan wrote: > This patch adds a property to automatically determine the NAND > bus width. This property works if the bus width is not specified > explicitly. > diff --git a/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt b/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt > +- gpio-control-nand,bank-width-auto : Device bus width is determined > + automatically if "bank-width" is omitted (Boolean). How would a driver determine the bank width automatically; is there some obvious way a driver should do this based on the/a NAND specification? Is there more than one way this auto-detection could occur, and if so, which of those methods is this property indicating will work? I'd rather expect the property description include details of the auto-detection mechanism that the DT states will work. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:57894 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258Ab3HSVKA (ORCPT ); Mon, 19 Aug 2013 17:10:00 -0400 Message-ID: <521289A3.5040705@wwwdotorg.org> Date: Mon, 19 Aug 2013 15:09:55 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH v4 1/4] mtd: nand: gpio: Add DT property to automatically determine bus width References: <1376637583-12485-1-git-send-email-shc_work@mail.ru> In-Reply-To: <1376637583-12485-1-git-send-email-shc_work@mail.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Alexander Shiyan Cc: linux-mtd@lists.infradead.org, David Woodhouse , Artem Bityutskiy , Brian Norris , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , devicetree@vger.kernel.org List-ID: On 08/16/2013 01:19 AM, Alexander Shiyan wrote: > This patch adds a property to automatically determine the NAND > bus width. This property works if the bus width is not specified > explicitly. > diff --git a/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt b/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt > +- gpio-control-nand,bank-width-auto : Device bus width is determined > + automatically if "bank-width" is omitted (Boolean). How would a driver determine the bank width automatically; is there some obvious way a driver should do this based on the/a NAND specification? Is there more than one way this auto-detection could occur, and if so, which of those methods is this property indicating will work? I'd rather expect the property description include details of the auto-detection mechanism that the DT states will work.