From: Chen Gang <gang.chen@asianux.com>
To: steffen.klassert@secunet.com
Cc: linux-crypto@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()
Date: Tue, 20 Aug 2013 11:43:32 +0800 [thread overview]
Message-ID: <5212E5E4.8010408@asianux.com> (raw)
When failure occures, __padata_add_cpu() and __padata_remove_cpu() will
return -ENOMEM, which need be noticed in any cases (even in cleaning up
cases).
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/padata.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 072f4ee..6a124cd 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -871,16 +871,20 @@ static int padata_cpu_callback(struct notifier_block *nfb,
if (!pinst_has_cpu(pinst, cpu))
break;
mutex_lock(&pinst->lock);
- __padata_remove_cpu(pinst, cpu);
+ err = __padata_remove_cpu(pinst, cpu);
mutex_unlock(&pinst->lock);
+ if (err)
+ return notifier_from_errno(err);
case CPU_DOWN_FAILED:
case CPU_DOWN_FAILED_FROZEN:
if (!pinst_has_cpu(pinst, cpu))
break;
mutex_lock(&pinst->lock);
- __padata_add_cpu(pinst, cpu);
+ err = __padata_add_cpu(pinst, cpu);
mutex_unlock(&pinst->lock);
+ if (err)
+ return notifier_from_errno(err);
}
return NOTIFY_OK;
--
1.7.7.6
next reply other threads:[~2013-08-20 3:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 3:43 Chen Gang [this message]
2013-08-20 3:44 ` [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu() Chen Gang
2013-08-22 5:11 ` Steffen Klassert
2013-08-22 5:27 ` Chen Gang
2013-08-22 6:05 ` Steffen Klassert
2013-08-22 6:16 ` Chen Gang
2013-08-22 6:43 ` [PATCH v2] kernel/padata.c: share code between CPU_ONLINE and CPU_DOWN_FAILED, same to CPU_DOWN_PREPARE and CPU_UP_CANCELED Chen Gang
2013-08-23 3:46 ` Chen Gang
2013-08-23 10:44 ` Steffen Klassert
2013-08-23 10:44 ` Steffen Klassert
2013-08-23 10:47 ` Herbert Xu
2013-08-23 10:47 ` Herbert Xu
2013-08-26 1:11 ` Chen Gang
2013-08-26 1:11 ` Chen Gang
2013-08-29 4:42 ` Herbert Xu
2013-08-29 4:42 ` Herbert Xu
2013-08-29 5:22 ` Chen Gang
2013-08-29 5:22 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212E5E4.8010408@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.