From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Gregory Subject: Re: [PATCH v2 0/5] mfd: twl6030-irq: rework and add twl6032 support Date: Tue, 20 Aug 2013 08:13:54 +0100 Message-ID: <52131732.2060306@slimlogic.co.uk> References: <1374758151-12097-1-git-send-email-grygorii.strashko@ti.com> <20130820010154.GB13324@zurbaran> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130820010154.GB13324@zurbaran> Sender: linux-kernel-owner@vger.kernel.org To: Samuel Ortiz Cc: Grygorii Strashko , Lee Jones , Kevin Hilman , linux-omap@vger.kernel.org, Ruslan Bilovol , linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 20/08/13 02:01, Samuel Ortiz wrote: > Hi Grygorii, > > On Thu, Jul 25, 2013 at 04:15:46PM +0300, Grygorii Strashko wrote: >> This patch series intorduces twl6030-irq module rework to use Threaded IRQ and >> linear irq_domain, and adds support for PMIC TWL6032 IRQs. >> >> After this patch series TWL6030/6032 IRQs will be supported only for DT boot mode. >> >> Changes since v1: >> - Added new patch "mfd: twl6030-irq: create struct twl6030_irq" >> which introduces "struct twl6030_irq" to store all local variables inside it. >> - Patch "mfd: twl6030-irq: migrate to IRQ threaded handler": >> Minor comments applied; fixed twl6030_exit_irq(); >> The Parent IRQ has been set for each nested IRQ. >> - Patch "mfd: twl6030-irq: convert to use linear irq_domain": >> The irq_find_mapping() is used in twl6030_mmc_card_detect_config() >> to get virtual IRQ number. > This looks good to me. Kevin, Graeme, any further comments/ACKs ? > > Cheers, > Samuel. > Yes, it looked good to me as well. Acked-by: Graeme Gregory G