From: Roland Stigge <stigge@antcom.de>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when using OF Platform"
Date: Tue, 20 Aug 2013 09:57:59 +0200 [thread overview]
Message-ID: <52132187.5030103@antcom.de> (raw)
In-Reply-To: <201308200629.r7K6TNUS010648@localhost.localdomain>
On 08/20/2013 08:29 AM, Christophe Leroy wrote:
> This patch reverts commit 047b93a35961f7a6561e6f5dcb040738f822b892 which breaks
> MAX7301 GPIO driver because that commit was dependant on a rejected patch that
> was implementing selection of SPI speed from the Device Tree.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Acked-by: Roland Stigge <stigge@antcom.de>
Good, thanks!
>
> --- linux-3.11-rc6/drivers/gpio/gpio-max7301.c 2013-08-17 21:09:17.000000000 +0200
> +++ linux/drivers/gpio/gpio-max7301.c 2013-08-18 06:31:52.000000000 +0200
> @@ -56,8 +56,7 @@
> int ret;
>
> /* bits_per_word cannot be configured in platform data */
> - if (spi->dev.platform_data)
> - spi->bits_per_word = 16;
> + spi->bits_per_word = 16;
> ret = spi_setup(spi);
> if (ret < 0)
> return ret;
>
next prev parent reply other threads:[~2013-08-20 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 6:29 [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when using OF Platform" Christophe Leroy
2013-08-20 7:57 ` Roland Stigge [this message]
2013-08-23 17:47 ` Linus Walleij
2013-08-24 16:55 ` christophe leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52132187.5030103@antcom.de \
--to=stigge@antcom.de \
--cc=christophe.leroy@c-s.fr \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.