From: Ian Abbott <abbotti@mev.co.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: pcmuio: remove an unneeded check
Date: Tue, 20 Aug 2013 10:02:45 +0000 [thread overview]
Message-ID: <52133EC5.30602@mev.co.uk> (raw)
In-Reply-To: <20130820090013.GC20170@elgon.mountain>
On 2013-08-20 10:00, Dan Carpenter wrote:
> "devpriv" is non-NULL at this point. We dereference it earlier in the
> function and the inconsistent checking upsets static checkers. We don't
> need to check "devpriv->sprivs" because kfree() accepts NULL pointers.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/comedi/drivers/pcmuio.c b/drivers/staging/comedi/drivers/pcmuio.c
> index f942455..a779062 100644
> --- a/drivers/staging/comedi/drivers/pcmuio.c
> +++ b/drivers/staging/comedi/drivers/pcmuio.c
> @@ -676,8 +676,7 @@ static void pcmuio_detach(struct comedi_device *dev)
> if (devpriv->asics[i].irq)
> free_irq(devpriv->asics[i].irq, dev);
> }
> - if (devpriv && devpriv->sprivs)
> - kfree(devpriv->sprivs);
> + kfree(devpriv->sprivs);
> comedi_legacy_detach(dev);
> }
>
>
Actually, the function is buggy anyway as devpriv might be NULL
(pcmuio_detach() is called even if pcmuio_attach() returns an error).
So let's drop this patch and I'll post a patch to fix the bug.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2013-08-20 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 9:00 [patch] staging: comedi: pcmuio: remove an unneeded check Dan Carpenter
2013-08-20 10:02 ` Ian Abbott [this message]
2013-08-20 10:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52133EC5.30602@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.