From: Ian Abbott <abbotti@mev.co.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: usbdux: allocating too much data
Date: Tue, 20 Aug 2013 10:09:35 +0000 [thread overview]
Message-ID: <5213405F.7070502@mev.co.uk> (raw)
In-Reply-To: <20130820090618.GD20170@elgon.mountain>
On 2013-08-20 10:06, Dan Carpenter wrote:
> We only need to allocate enough space for a pointer. We allocate the
> space for the urbs themselves with the call to usb_alloc_urb() a few
> lines later.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Untested.
>
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index 7e91f15..701ad1a 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -1558,9 +1558,9 @@ static int usbdux_alloc_usb_buffers(struct comedi_device *dev)
> devpriv->dux_commands = kzalloc(SIZEOFDUXBUFFER, GFP_KERNEL);
> devpriv->in_buf = kzalloc(SIZEINBUF, GFP_KERNEL);
> devpriv->insn_buf = kzalloc(SIZEINSNBUF, GFP_KERNEL);
> - devpriv->ai_urbs = kcalloc(devpriv->n_ai_urbs, sizeof(*urb),
> + devpriv->ai_urbs = kcalloc(devpriv->n_ai_urbs, sizeof(void *),
> GFP_KERNEL);
> - devpriv->ao_urbs = kcalloc(devpriv->n_ao_urbs, sizeof(*urb),
> + devpriv->ao_urbs = kcalloc(devpriv->n_ao_urbs, sizeof(void *),
> GFP_KERNEL);
> if (!devpriv->dux_commands || !devpriv->in_buf || !devpriv->insn_buf ||
> !devpriv->ai_urbs || !devpriv->ao_urbs)
>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Also, usbduxsigma.c has the same problem.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2013-08-20 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 9:06 [patch] staging: comedi: usbdux: allocating too much data Dan Carpenter
2013-08-20 10:09 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5213405F.7070502@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.