From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Romanick <idr@freedesktop.org>
Subject: Re: [PATCH 8/8] drm: Make drm_get_platform_dev() static
Date: Tue, 20 Aug 2013 07:56:42 -0700
Message-ID: <521383AA.1060908@freedesktop.org>
References: <1376956390-12124-1-git-send-email-damien.lespiau@intel.com>
	<1376956390-12124-9-git-send-email-damien.lespiau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from expn.cat.pdx.edu (expn.cat.pdx.edu [131.252.208.110])
	by gabe.freedesktop.org (Postfix) with ESMTP id 551E2E5DC2
	for <dri-devel@lists.freedesktop.org>;
	Tue, 20 Aug 2013 07:56:51 -0700 (PDT)
In-Reply-To: <1376956390-12124-9-git-send-email-damien.lespiau@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 08/19/2013 04:53 PM, Damien Lespiau wrote:
> It's only used in drm_platform.c.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>   drivers/gpu/drm/drm_platform.c | 7 +++----
>   include/drm/drmP.h             | 3 ---
>   2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_platform.c b/drivers/gpu/drm/drm_platform.c
> index b8a282e..400024b 100644
> --- a/drivers/gpu/drm/drm_platform.c
> +++ b/drivers/gpu/drm/drm_platform.c
> @@ -28,7 +28,7 @@
>   #include <linux/export.h>
>   #include <drm/drmP.h>
>
> -/**
> +/*
>    * Register.
>    *
>    * \param platdev - Platform device struture

Was this change intentional?  The rest of the comment is doxygen still.

> @@ -39,8 +39,8 @@
>    * Try and register, if we fail to register, backout previous work.
>    */
>
> -int drm_get_platform_dev(struct platform_device *platdev,
> -			 struct drm_driver *driver)
> +static int drm_get_platform_dev(struct platform_device *platdev,
> +				struct drm_driver *driver)
>   {
>   	struct drm_device *dev;
>   	int ret;
> @@ -107,7 +107,6 @@ err_g1:
>   	mutex_unlock(&drm_global_mutex);
>   	return ret;
>   }
> -EXPORT_SYMBOL(drm_get_platform_dev);
>
>   static int drm_platform_get_irq(struct drm_device *dev)
>   {
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 046a7db..1a7a78f 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1657,9 +1657,6 @@ extern int drm_pcie_get_speed_cap_mask(struct drm_device *dev, u32 *speed_mask);
>   extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
>   extern void drm_platform_exit(struct drm_driver *driver, struct platform_device *platform_device);
>
> -extern int drm_get_platform_dev(struct platform_device *pdev,
> -				struct drm_driver *driver);
> -
>   /* returns true if currently okay to sleep */
>   static __inline__ bool drm_can_sleep(void)
>   {
>