All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daiane Angolini <daiane.angolini@freescale.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: meta-freescale Mailing List <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm-extra PATCH 2/2] Rework machines to use dtb file in KERNEL_DEVICETREE variable
Date: Tue, 20 Aug 2013 12:49:15 -0300	[thread overview]
Message-ID: <52138FFB.7060002@freescale.com> (raw)
In-Reply-To: <1376966021-14699-2-git-send-email-otavio@ossystems.com.br>

I'm sorry, I was not able to review your patches yesterday.

On 08/19/2013 11:33 PM, Otavio Salvador wrote:
> The linux-dtb.inc has been rework to use the Linux kernel build system

The linux-dtb.inc has been *reworked* to use the Linux......

> to generate the DeviceTree binaries so now KERNEL_DEVICETREE variable
> should has the /target/ name, not the file path. This patch rework

blablabla. This patch *reworks*

> following machines:
>
>   - imx233-olinuxino-*
>   - m28evk
>   - m53evk
>
> Change-Id: I824e818f50de094fe1b25ef3ea202abd90093650
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>   conf/machine/include/imx233-olinuxino.inc | 2 +-
>   conf/machine/m28evk.conf                  | 2 +-
>   conf/machine/m53evk.conf                  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/conf/machine/include/imx233-olinuxino.inc b/conf/machine/include/imx233-olinuxino.inc
> index 9c4e9d9..c0b400b 100644
> --- a/conf/machine/include/imx233-olinuxino.inc
> +++ b/conf/machine/include/imx233-olinuxino.inc
> @@ -9,7 +9,7 @@ UBOOT_MACHINE = "mx23_olinuxino_config"
>   SOC_FAMILY = "mxs:mx23:imx233-olinuxino"
>
>   KERNEL_IMAGETYPE = "uImage"
> -KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx23-olinuxino.dts"
> +KERNEL_DEVICETREE = "imx23-olinuxino.dtb"
>
>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> diff --git a/conf/machine/m28evk.conf b/conf/machine/m28evk.conf
> index 675d56a..ec8af0e 100644
> --- a/conf/machine/m28evk.conf
> +++ b/conf/machine/m28evk.conf
> @@ -11,7 +11,7 @@ UBOOT_MACHINE = "m28evk_config"
>
>   PREFERRED_PROVIDER_virtual/kernel = "linux-fslc"
>   KERNEL_IMAGETYPE = "uImage"
> -KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx28-m28evk.dts"
> +KERNEL_DEVICETREE = "imx28-m28evk.dtb"
>
>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> diff --git a/conf/machine/m53evk.conf b/conf/machine/m53evk.conf
> index 293aa66..33f9cef 100644
> --- a/conf/machine/m53evk.conf
> +++ b/conf/machine/m53evk.conf
> @@ -13,7 +13,7 @@ UBOOT_MACHINE = "m53evk_config"
>   PREFERRED_PROVIDER_virtual/kernel = "linux-denx"
>
>   KERNEL_IMAGETYPE = "uImage"
> -KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx53-m53evk.dts"
> +KERNEL_DEVICETREE = "imx53-m53evk.dtb"
>
>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"
>

Everything else looks fine.


-- 
Daiane



  reply	other threads:[~2013-08-20 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20  2:33 [meta-fsl-arm-extra PATCH 1/2] m53evk: Remove duplicated setting of U-Boot preferred provider Otavio Salvador
2013-08-20  2:33 ` [meta-fsl-arm-extra PATCH 2/2] Rework machines to use dtb file in KERNEL_DEVICETREE variable Otavio Salvador
2013-08-20 15:49   ` Daiane Angolini [this message]
2013-08-20 16:51     ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52138FFB.7060002@freescale.com \
    --to=daiane.angolini@freescale.com \
    --cc=meta-freescale@yoctoproject.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.