From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver Date: Tue, 20 Aug 2013 10:17:04 -0600 Message-ID: <52139680.1010800@wwwdotorg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Nicolin Chen Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, festevam@gmail.com, s.hauer@pengutronix.de, timur@tabi.org, rob.herring@calxeda.com, tomasz.figa@gmail.com, broonie@kernel.org, p.zabel@pengutronix.de, R65777@freescale.com, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org On 08/19/2013 10:32 PM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. > > Signed-off-by: Nicolin Chen > --- > .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 +++++ What changed between v8 and v9? > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt b/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt > +Optional properties: > + > + - spdif-transmitter : The phandle of the spdif-transmitter dummy codec > + > + - spdif-receiver : The phandle of the spdif-receiver dummy codec > + > +* Note: At least one of these two properties should be set in the DT binding. I still don't think "dummy CODEC" is an appropriate thing to have in DT. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:60831 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255Ab3HTQRJ (ORCPT ); Tue, 20 Aug 2013 12:17:09 -0400 Message-ID: <52139680.1010800@wwwdotorg.org> Date: Tue, 20 Aug 2013 10:17:04 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Nicolin Chen Cc: broonie@kernel.org, s.hauer@pengutronix.de, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, lars@metafoo.de, p.zabel@pengutronix.de, timur@tabi.org, rob.herring@calxeda.com, shawn.guo@linaro.org, festevam@gmail.com, tomasz.figa@gmail.com, mark.rutland@arm.com, R65777@freescale.com List-ID: On 08/19/2013 10:32 PM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. > > Signed-off-by: Nicolin Chen > --- > .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 +++++ What changed between v8 and v9? > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt b/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt > +Optional properties: > + > + - spdif-transmitter : The phandle of the spdif-transmitter dummy codec > + > + - spdif-receiver : The phandle of the spdif-receiver dummy codec > + > +* Note: At least one of these two properties should be set in the DT binding. I still don't think "dummy CODEC" is an appropriate thing to have in DT.