All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: fix SPI_BIT_MASK() to use correct size for 32-bit transfer mask
Date: Tue, 20 Aug 2013 10:37:34 -0600	[thread overview]
Message-ID: <52139B4E.6070700@wwwdotorg.org> (raw)
In-Reply-To: <1377000932-5438-1-git-send-email-mika.westerberg@linux.intel.com>

On 08/20/2013 06:15 AM, Mika Westerberg wrote:
> When building a 64-bit kernel we get the following warning from the
> compiler:
> 
>  drivers/spi/spi-pxa2xx.c: In function ‘pxa2xx_spi_probe’:
>  drivers/spi/spi-pxa2xx.c:1152:3: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>    master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32);
>    ^
> This is due the fact that when the max range is specified as 32
> SPI_BIT_MASK() expands to ~0UL which doesn't fit to the u32 type that the
> master->bits_per_word_mask is.
> 
> Fix this by using ~0U instead.

The same patch is already in next-20130819 at least, as:
b6aa23c spi: fix SPI_BIT_MASK so it always fits into 32-bits

  reply	other threads:[~2013-08-20 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 12:15 [PATCH] spi: fix SPI_BIT_MASK() to use correct size for 32-bit transfer mask Mika Westerberg
2013-08-20 16:37 ` Stephen Warren [this message]
2013-08-21  7:44   ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52139B4E.6070700@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.