From: Felix Fietkau <nbd@openwrt.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: Linux Wireless List <linux-wireless@vger.kernel.org>
Subject: Re: [REGRESSION] 3.10.{6,7} crashes on network activity
Date: Tue, 20 Aug 2013 19:36:38 +0200 [thread overview]
Message-ID: <5213A926.8060306@openwrt.org> (raw)
In-Reply-To: <52132589.5000306@broadcom.com>
On 2013-08-20 10:15 AM, Arend van Spriel wrote:
> Hi Felix,
>
> I have been diving into root causing why brcmsmac can not handle cck
> fallback rates, because it should. Maybe it is better to flag no cck
> support and only change brcmsmac.
I prefer having a flag to enable it over one to disable it, because it
fits better with the existing flags. Also, future drivers may not always
be properly prepared to handle CCK in A-MPDU sessions either.
By the way, I took a short look at brcmsmac and found more issues that
you should look into if you want to fix this.
First of all, you should probably make sure that the hardware does not
try to send an A-MPDU using a CCK rate (prepare it as a single frame in
brcms_c_ampdu_add_frame). It also does not seem to have any checks to
ensure that rate control probing frames are not aggregated.
- Felix
next prev parent reply other threads:[~2013-08-20 17:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAG-2HqUXQeq=30EpGWmn6tkC=CP1W+=UZCVPTYhhE0WyU_C4nw@mail.gmail.com>
2013-08-20 0:03 ` [REGRESSION] 3.10.{6,7} crashes on network activity Greg Kroah-Hartman
2013-08-20 0:26 ` Tom Gundersen
2013-08-20 0:28 ` Greg Kroah-Hartman
2013-08-20 4:56 ` Felix Fietkau
2013-08-20 8:15 ` Arend van Spriel
2013-08-20 8:36 ` Tom Gundersen
2013-08-20 9:58 ` Arend van Spriel
2013-08-20 10:10 ` Georgios Magklaras
2013-08-20 17:36 ` Felix Fietkau [this message]
2013-08-20 19:04 ` Arend van Spriel
2013-08-21 0:11 ` Josh Boyer
2013-08-21 8:52 ` Arend van Spriel
2013-08-21 12:38 ` Josh Boyer
2013-08-21 14:27 ` Arend van Spriel
2013-08-21 14:45 ` Josh Boyer
2013-08-20 8:34 ` Tom Gundersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5213A926.8060306@openwrt.org \
--to=nbd@openwrt.org \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.