From: Anand Jain <Anand.Jain@oracle.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 3/3] btrfs-progs: avoid write to the disk before sure to create fs
Date: Wed, 21 Aug 2013 11:15:59 +0800 [thread overview]
Message-ID: <521430EF.5050409@oracle.com> (raw)
In-Reply-To: <20130820191941.GJ3990@localhost.localdomain>
On 08/21/2013 03:19 AM, Josef Bacik wrote:
> On Wed, Aug 07, 2013 at 08:11:25PM +0800, Anand Jain wrote:
>> This patch provides fix for the following bug,
>>
>> When mkfs.btrfs fails the disks shouldn't be written.
>> ------------
>> btrfs fi show /dev/sdb
>> Label: none uuid: 60fb76f4-3b4d-4632-a7da-6a44dea5573d
>> Total devices 1 FS bytes used 24.00KiB
>> devid 1 size 2.00GiB used 20.00MiB path /dev/sdb
>>
>> mkfs.btrfs -dsingle -mraid1 /dev/sdb -f
>> ::
>> unable to create FS with metadata profile 16 (have 1 devices)
>>
>> btrfs fi show /dev/sdb
>> Label: none uuid: 2da2179d-ecb1-4a4e-a44d-e7613a08c18d
>> Total devices 1 FS bytes used 24.00KiB
>> devid 1 size 2.00GiB used 20.00MiB path /dev/sdb
>> -------------
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> This regresses making a filesystem that is forced to be a mixed block group.
I guess you are talking about the regression which was addressed
by the below patch:
[PATCH] btrfs-progs: mkfs should check for small vol well before
If this doesn't help, kindly provide the test case.
I tried with the usual forced Mixed option it just works fine.
prev parent reply other threads:[~2013-08-21 3:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 17:35 [PATCH 0/6] Anand Jain
2013-07-25 17:35 ` [PATCH 1/6] btrfs-progs: close_all_devices() in btrfs-find-root.c does nothing Anand Jain
2013-07-25 17:35 ` [PATCH 2/6] btrfs-progs: let user know that devid can be used if path is missing Anand Jain
2013-07-25 17:35 ` [PATCH 3/6] btrfs-progs: cmd_start_replace() to use test_dev_for_mkfs() Anand Jain
2013-07-25 17:35 ` [PATCH 4/6] btrfs-progs: mkfs.c overwrites fd without appropriate close Anand Jain
2013-08-13 19:14 ` Josef Bacik
2013-08-13 19:19 ` Josef Bacik
2013-08-14 2:04 ` Anand Jain
2013-08-14 3:17 ` Anand Jain
2013-08-14 13:32 ` Josef Bacik
2013-08-14 4:37 ` [PATCH] btrfs-progs: Fix: mkfs.c overwrites fd without appropriate close patch Anand Jain
2013-07-25 17:35 ` [PATCH 5/6] btrfs-progs: avoid write to the disk before sure to create fs Anand Jain
2013-07-25 17:35 ` [PATCH 6/6] btrfs-progs: don't have to report ENOMEDIUM error during open Anand Jain
2013-08-07 12:11 ` [PATCH 0/3 resend] Anand Jain
2013-08-07 12:11 ` [PATCH 1/3] btrfs-progs: let user know that devid can be used if path is missing Anand Jain
2013-08-07 12:11 ` [PATCH 2/3] btrfs-progs: cmd_start_replace() to use test_dev_for_mkfs() Anand Jain
2013-08-07 12:11 ` [PATCH 3/3] btrfs-progs: avoid write to the disk before sure to create fs Anand Jain
2013-08-20 19:19 ` Josef Bacik
2013-08-21 3:15 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521430EF.5050409@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.