From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Bonn Subject: Re: [RFC PATCH 2/4] openrisc: remove undefined of_get_cpu_node declaration Date: Wed, 21 Aug 2013 07:10:33 +0200 Message-ID: <52144BC9.9030007@southpole.se> References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-3-git-send-email-Sudeep.KarkadaNagesha@arm.com> <520DF3BD.2070904@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <520DF3BD.2070904@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Sudeep KarkadaNagesha Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Benjamin Herrenschmidt , Michal Simek , "Rafael J. Wysocki" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" List-Id: linux-pm@vger.kernel.org On 08/16/13 11:41, Sudeep KarkadaNagesha wrote: > On 15/08/13 18:09, Sudeep KarkadaNagesha wrote: >> From: Sudeep KarkadaNagesha >> >> This patch removes the declaration of the function 'of_get_cpu_node' >> which is not defined for openrisc. This is in preparation to move >> it's definition from PPC to DT common code. >> >> Again it could be there as it was originally copied from powerpc. >> >> Signed-off-by: Sudeep KarkadaNagesha >> Cc: Jonas Bonn > Hi Jonas, > > Since both microblaze and openrisc have moderated lists which I am not > member of, these patches were blocked. Michal Simek agreed to remove > this for microblaze. Do you see any concern with this patch for openrisc > ? Can I have you ACK if it looks fine ? Hi Sudeep, Yes, thanks, the patch looks good. Acked-by: Jonas Bonn /Jonas > > Regards, > Sudeep >> --- >> arch/openrisc/include/asm/prom.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/openrisc/include/asm/prom.h b/arch/openrisc/include/asm/prom.h >> index bbb34e5..eb59bfe 100644 >> --- a/arch/openrisc/include/asm/prom.h >> +++ b/arch/openrisc/include/asm/prom.h >> @@ -44,9 +44,6 @@ void of_parse_dma_window(struct device_node *dn, const void *dma_window_prop, >> >> extern void kdump_move_device_tree(void); >> >> -/* CPU OF node matching */ >> -struct device_node *of_get_cpu_node(int cpu, unsigned int *thread); >> - >> /* Get the MAC address */ >> extern const void *of_get_mac_address(struct device_node *np); >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.southpole.se (mail.southpole.se [IPv6:2a01:3b8:2831:1::11]) by ozlabs.org (Postfix) with ESMTP id 4DD992C011E for ; Wed, 21 Aug 2013 15:30:13 +1000 (EST) Message-ID: <52144BC9.9030007@southpole.se> Date: Wed, 21 Aug 2013 07:10:33 +0200 From: Jonas Bonn MIME-Version: 1.0 To: Sudeep KarkadaNagesha Subject: Re: [RFC PATCH 2/4] openrisc: remove undefined of_get_cpu_node declaration References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-3-git-send-email-Sudeep.KarkadaNagesha@arm.com> <520DF3BD.2070904@arm.com> In-Reply-To: <520DF3BD.2070904@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Cc: "devicetree@vger.kernel.org" , Michal Simek , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "Rafael J. Wysocki" , "grant.likely@linaro.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/16/13 11:41, Sudeep KarkadaNagesha wrote: > On 15/08/13 18:09, Sudeep KarkadaNagesha wrote: >> From: Sudeep KarkadaNagesha >> >> This patch removes the declaration of the function 'of_get_cpu_node' >> which is not defined for openrisc. This is in preparation to move >> it's definition from PPC to DT common code. >> >> Again it could be there as it was originally copied from powerpc. >> >> Signed-off-by: Sudeep KarkadaNagesha >> Cc: Jonas Bonn > Hi Jonas, > > Since both microblaze and openrisc have moderated lists which I am not > member of, these patches were blocked. Michal Simek agreed to remove > this for microblaze. Do you see any concern with this patch for openrisc > ? Can I have you ACK if it looks fine ? Hi Sudeep, Yes, thanks, the patch looks good. Acked-by: Jonas Bonn /Jonas > > Regards, > Sudeep >> --- >> arch/openrisc/include/asm/prom.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/openrisc/include/asm/prom.h b/arch/openrisc/include/asm/prom.h >> index bbb34e5..eb59bfe 100644 >> --- a/arch/openrisc/include/asm/prom.h >> +++ b/arch/openrisc/include/asm/prom.h >> @@ -44,9 +44,6 @@ void of_parse_dma_window(struct device_node *dn, const void *dma_window_prop, >> >> extern void kdump_move_device_tree(void); >> >> -/* CPU OF node matching */ >> -struct device_node *of_get_cpu_node(int cpu, unsigned int *thread); >> - >> /* Get the MAC address */ >> extern const void *of_get_mac_address(struct device_node *np); >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonas@southpole.se (Jonas Bonn) Date: Wed, 21 Aug 2013 07:10:33 +0200 Subject: [RFC PATCH 2/4] openrisc: remove undefined of_get_cpu_node declaration In-Reply-To: <520DF3BD.2070904@arm.com> References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-3-git-send-email-Sudeep.KarkadaNagesha@arm.com> <520DF3BD.2070904@arm.com> Message-ID: <52144BC9.9030007@southpole.se> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/16/13 11:41, Sudeep KarkadaNagesha wrote: > On 15/08/13 18:09, Sudeep KarkadaNagesha wrote: >> From: Sudeep KarkadaNagesha >> >> This patch removes the declaration of the function 'of_get_cpu_node' >> which is not defined for openrisc. This is in preparation to move >> it's definition from PPC to DT common code. >> >> Again it could be there as it was originally copied from powerpc. >> >> Signed-off-by: Sudeep KarkadaNagesha >> Cc: Jonas Bonn > Hi Jonas, > > Since both microblaze and openrisc have moderated lists which I am not > member of, these patches were blocked. Michal Simek agreed to remove > this for microblaze. Do you see any concern with this patch for openrisc > ? Can I have you ACK if it looks fine ? Hi Sudeep, Yes, thanks, the patch looks good. Acked-by: Jonas Bonn /Jonas > > Regards, > Sudeep >> --- >> arch/openrisc/include/asm/prom.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/openrisc/include/asm/prom.h b/arch/openrisc/include/asm/prom.h >> index bbb34e5..eb59bfe 100644 >> --- a/arch/openrisc/include/asm/prom.h >> +++ b/arch/openrisc/include/asm/prom.h >> @@ -44,9 +44,6 @@ void of_parse_dma_window(struct device_node *dn, const void *dma_window_prop, >> >> extern void kdump_move_device_tree(void); >> >> -/* CPU OF node matching */ >> -struct device_node *of_get_cpu_node(int cpu, unsigned int *thread); >> - >> /* Get the MAC address */ >> extern const void *of_get_mac_address(struct device_node *np); >> >> >