From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Kerr Subject: Re: linux-next: build failure after merge of the final tree Date: Wed, 21 Aug 2013 14:30:04 +0800 Message-ID: <52145E6C.80404@ozlabs.org> References: <20130820172052.1f0d89ddf6a1a40ef70333fd@canb.auug.org.au> <20130820120702.000b044e@oracle.com> <201308202246.30869.arnd@arndb.de> <20130821010822.220f592a@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130821010822.220f592a@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dwight Engen Cc: cbe-oss-dev@lists.ozlabs.org, Stephen Rothwell , Arnd Bergmann , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Ben Myers , linux-next@vger.kernel.org, Gao feng , linuxppc-dev@lists.ozlabs.org List-Id: linux-next.vger.kernel.org Hi all, > Yes, I agree. The other filesystems that take an Opt_uid as well do use > current_user_ns() and not init_user_ns. They also do a uid_valid() > check and fail the mount (or fallback to GLOBAL_ROOT_UID). So I think > that would look like this: Looks good to me. Builds and mounts as expected. Acked-by: Jeremy Kerr Cheers, Jeremy _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <52145E6C.80404@ozlabs.org> Date: Wed, 21 Aug 2013 14:30:04 +0800 From: Jeremy Kerr MIME-Version: 1.0 To: Dwight Engen Subject: Re: linux-next: build failure after merge of the final tree References: <20130820172052.1f0d89ddf6a1a40ef70333fd@canb.auug.org.au> <20130820120702.000b044e@oracle.com> <201308202246.30869.arnd@arndb.de> <20130821010822.220f592a@oracle.com> In-Reply-To: <20130821010822.220f592a@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: cbe-oss-dev@lists.ozlabs.org, Stephen Rothwell , Arnd Bergmann , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Ben Myers , linux-next@vger.kernel.org, Gao feng , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi all, > Yes, I agree. The other filesystems that take an Opt_uid as well do use > current_user_ns() and not init_user_ns. They also do a uid_valid() > check and fail the mount (or fallback to GLOBAL_ROOT_UID). So I think > that would look like this: Looks good to me. Builds and mounts as expected. Acked-by: Jeremy Kerr Cheers, Jeremy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752347Ab3HUGaM (ORCPT ); Wed, 21 Aug 2013 02:30:12 -0400 Received: from ozlabs.org ([203.10.76.45]:35263 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257Ab3HUGaH (ORCPT ); Wed, 21 Aug 2013 02:30:07 -0400 Message-ID: <52145E6C.80404@ozlabs.org> Date: Wed, 21 Aug 2013 14:30:04 +0800 From: Jeremy Kerr User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Dwight Engen CC: Arnd Bergmann , cbe-oss-dev@lists.ozlabs.org, Stephen Rothwell , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Ben Myers , linux-next@vger.kernel.org, Gao feng , linuxppc-dev@lists.ozlabs.org Subject: Re: linux-next: build failure after merge of the final tree References: <20130820172052.1f0d89ddf6a1a40ef70333fd@canb.auug.org.au> <20130820120702.000b044e@oracle.com> <201308202246.30869.arnd@arndb.de> <20130821010822.220f592a@oracle.com> In-Reply-To: <20130821010822.220f592a@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, > Yes, I agree. The other filesystems that take an Opt_uid as well do use > current_user_ns() and not init_user_ns. They also do a uid_valid() > check and fail the mount (or fallback to GLOBAL_ROOT_UID). So I think > that would look like this: Looks good to me. Builds and mounts as expected. Acked-by: Jeremy Kerr Cheers, Jeremy