From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file
Date: Wed, 21 Aug 2013 10:25:18 +0200 [thread overview]
Message-ID: <5214796E.5050000@samsung.com> (raw)
In-Reply-To: <5211C608.60201@xs4all.nl>
Hi Hans,
On 08/19/2013 09:15 AM, Hans Verkuil wrote:
> On 08/18/2013 10:00 PM, Sylwester Nawrocki wrote:
>> Include the v4l2-dv-timings.h header file which in the s5p-tv driver which
>> was supposed to be updated in commit 2576415846bcbad3c0a6885fc44f95083710
>> "[media] v4l2: move dv-timings related code to v4l2-dv-timings.c"
>>
>> This fixes following build error:
>>
>> drivers/media/platform/s5p-tv/hdmi_drv.c: In function ‘hdmi_s_dv_timings’:
>> drivers/media/platform/s5p-tv/hdmi_drv.c:628:3: error: implicit declaration of function ‘v4l_match_dv_timings’
>>
>> Cc: Hans Verkuil <hans.verkuil@cisco.com>
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> My apologies for missing this one.
That's all right. Shit happens. I was wondering why this error
didn't show up in your daily builds.
--
Regards,
Sylwester
next prev parent reply other threads:[~2013-08-21 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 20:00 [PATCH] s5p-tv: Include missing v4l2-dv-timings.h header file Sylwester Nawrocki
2013-08-19 7:15 ` Hans Verkuil
2013-08-21 8:25 ` Sylwester Nawrocki [this message]
2013-08-21 8:38 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214796E.5050000@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.