All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fec_mxc: set ethaddr if fuses burned and not previously set
Date: Wed, 21 Aug 2013 06:28:14 -0700	[thread overview]
Message-ID: <5214C06E.6010406@boundarydevices.com> (raw)
In-Reply-To: <5214A23F.2070108@denx.de>

On 08/21/2013 04:19 AM, Stefano Babic wrote:
> Hi Eric,
>
> On 02/08/2013 19:37, Eric Nelson wrote:
>> Without this change, the following message is generated:
>> 	Warning: FEC using MAC address from net device
>>
>> See doc/README.enetaddr for details.
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>>   drivers/net/fec_mxc.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
>> index e14a359..886be9c 100644
>> --- a/drivers/net/fec_mxc.c
>> +++ b/drivers/net/fec_mxc.c
>> @@ -980,6 +980,8 @@ static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
>>   	if (fec_get_hwaddr(edev, dev_id, ethaddr) == 0) {
>>   		debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
>>   		memcpy(edev->enetaddr, ethaddr, 6);
>> +		if (!getenv("ethaddr"))
>> +			eth_setenv_enetaddr("ethaddr",mac);
>                                                         ^--
> of course, this should be ethaddr and not mac. I fixed it myself.
>
Thanks Stefano.

      reply	other threads:[~2013-08-21 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 17:37 [U-Boot] [PATCH] fec_mxc: set ethaddr if fuses burned and not previously set Eric Nelson
2013-08-21 10:42 ` Stefano Babic
2013-08-21 11:19 ` Stefano Babic
2013-08-21 13:28   ` Eric Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5214C06E.6010406@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.