From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sathya Perla <sathya.perla@emulex.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] be2net: fix disabling TX in be_close()
Date: Wed, 21 Aug 2013 18:48:43 +0400 [thread overview]
Message-ID: <5214D34B.8080701@cogentembedded.com> (raw)
In-Reply-To: <1377080534-19509-1-git-send-email-sathya.perla@emulex.com>
Hello.
On 21-08-2013 14:22, Sathya Perla wrote:
> commit fba875591 disabled TX in be_close() to protect be_xmit() from
Please also specify that commit's summary line in parens.
> touching freed up queues in the AER recovery flow.
> But, TX must be disabled *before* cleaning up TX completions in the
> close() path, not after. This allows be_tx_compl_clean() to free up
> all TX-req skbs that were notified to the HW.
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
WBR, Sergei
prev parent reply other threads:[~2013-08-21 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 10:22 [PATCH] be2net: fix disabling TX in be_close() Sathya Perla
2013-08-21 14:48 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214D34B.8080701@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.