From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Wed, 21 Aug 2013 17:10:14 +0200 Subject: [U-Boot] [PATCH 2/4] gpio: atmel: remove the at91_pio definition In-Reply-To: <1376375912-13835-3-git-send-email-voice.shen@atmel.com> References: <1376375912-13835-1-git-send-email-voice.shen@atmel.com> <1376375912-13835-3-git-send-email-voice.shen@atmel.com> Message-ID: <5214D856.6050405@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/13/2013 08:38 AM, Bo Shen wrote: > the at91_pio definition is no longer needed, so remove it > > Signed-off-by: Bo Shen > --- > arch/arm/include/asm/arch-at91/at91_pio.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h b/arch/arm/include/asm/arch-at91/at91_pio.h > index 676f024..ba61542 100644 > --- a/arch/arm/include/asm/arch-at91/at91_pio.h > +++ b/arch/arm/include/asm/arch-at91/at91_pio.h > @@ -109,21 +109,6 @@ typedef struct at91_port { > #endif > } at91_port_t; > > -typedef union at91_pio { > - struct { > - at91_port_t pioa; > - at91_port_t piob; > - at91_port_t pioc; > - #if (ATMEL_PIO_PORTS > 3) > - at91_port_t piod; > - #endif > - #if (ATMEL_PIO_PORTS > 4) > - at91_port_t pioe; > - #endif > - } ; > - at91_port_t port[ATMEL_PIO_PORTS]; > -} at91_pio_t; > - NAK, this breaks at least 7 boards: 14: gpio: atmel: remove the at91_pio definition arm: + at91sam9263ek_dataflash_cs0 eb_cpux9k2 at91rm9200ek_ram cpuat91 vl_ma2sc vl_ma2sc_ram cpuat91_ram We need to have this typedef while we have the new API and change the users of this struct to the new API after introducing. Best regards Andreas Bie?mann