From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the aio tree
Date: Wed, 21 Aug 2013 10:52:27 -0500 [thread overview]
Message-ID: <5214E23B.9060608@oracle.com> (raw)
In-Reply-To: <20130821174522.3af60c89647476d2aab5f47c@canb.auug.org.au>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stephen,
There's another problem after the merge. Now that buf is passed into
aio_run_iocb(), ki_iter is no longer needed. It's not getting
initialized and causes an oops.
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
- ---
fs/aio.c | 4 ++--
include/linux/aio.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/aio.c b/fs/aio.c
index 59b46cd..9f783e3 100644
- --- a/fs/aio.c
+++ b/fs/aio.c
@@ -1281,11 +1281,11 @@ rw_common:
break;
case IOCB_CMD_READ_ITER:
- - ret = aio_read_iter(req, req->ki_iter);
+ ret = aio_read_iter(req, (void *)buf);
break;
case IOCB_CMD_WRITE_ITER:
- - ret = aio_write_iter(req, req->ki_iter);
+ ret = aio_write_iter(req, (void *)buf);
break;
case IOCB_CMD_FDSYNC:
diff --git a/include/linux/aio.h b/include/linux/aio.h
index 4fab377..c08d3ed 100644
- --- a/include/linux/aio.h
+++ b/include/linux/aio.h
@@ -54,7 +54,6 @@ struct kiocb {
* this is the underlying eventfd context to deliver events to.
*/
struct eventfd_ctx *ki_eventfd;
- - struct iov_iter *ki_iter;
};
static inline bool is_sync_kiocb(struct kiocb *kiocb)
- --
1.8.3.4
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSFOI7AAoJEDaohF61QIxkuW4P/3XIggPvVE3ZypC2Qno9UwtB
KXCVu0A0eLNbA6tB82vCWaQ7IblazoCOAex74qpGGrSB4ReS8yJDHkqnFR1aK8i4
Jyi2EONVUzAq5ijH9amZQfFWwcXBsH6nb2uEcv/xQ2/lc1hPCl3kIy/fKYVRWfYB
7YfX5J3VQnrI28B8NEccfqtTdQlYGp7VaRbh9dKVsudjBZZW9LAMkNcWoFuJzL9l
mAtubeUSaq9F7Dp6p/8whXyh5Ue2jPKo2m87B1et9Y5RN+K45uX3hTUJcAdKY72k
p9U4KNTCFG5o5FfsxI62B3/41R7KeOSe0PvILmb822vxLBnQWgF+fTScswKDDUcP
BFLoKE0WeCgzBiIPLEHaxJZSW7wUJqYAYGrnHRM8yFjJHUMDkWjiNN/597MDbijF
5BBj+gLN2GiBxKQcjtZRTXpUZ2pThLhPYpz/REtS134wz3Hp+ftsytHISCeUUoso
Icf8qd+JmggLOugdXg0gq7LAAc7Wnm91TJ79jsXFc7HPRBKl7AflS3e5poSQoy+Y
YZfVCUWV8LAnnB/fa9JobCIajIOebhhODpd5Y1hcqd9YDrqzhF3KlwyQkAmy9e2x
kX2dvHcumSNkYzWmQnP8Yol7oDWA9XXaL0nYRKDkpy/3F9+pCeheO1bY7tUnMD9F
34UQznE6M8rRkgiRKGDe
=WSg+
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-08-21 15:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 7:45 linux-next: build failure after merge of the aio tree Stephen Rothwell
2013-08-21 15:52 ` Dave Kleikamp [this message]
2013-08-21 23:53 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2013-08-30 7:55 Stephen Rothwell
2013-08-30 14:26 ` Benjamin LaHaise
2013-08-30 17:38 ` Linus Torvalds
2013-08-30 17:42 ` Benjamin LaHaise
2016-01-12 5:40 Stephen Rothwell
2016-01-12 16:38 ` Benjamin LaHaise
2016-01-27 2:40 ` Stephen Rothwell
2016-01-27 2:40 ` Stephen Rothwell
2016-01-29 11:30 ` Russell King - ARM Linux
2016-01-29 11:30 ` Russell King - ARM Linux
2016-01-29 12:03 ` Geert Uytterhoeven
2016-01-29 12:03 ` Geert Uytterhoeven
2016-02-04 2:19 ` Stephen Rothwell
2016-02-04 2:19 ` Stephen Rothwell
2016-02-04 13:41 ` Benjamin LaHaise
2016-02-04 13:41 ` Benjamin LaHaise
2016-02-04 13:50 ` Russell King - ARM Linux
2016-02-04 13:50 ` Russell King - ARM Linux
2016-02-04 14:08 ` Benjamin LaHaise
2016-02-04 14:08 ` Benjamin LaHaise
2016-02-04 14:12 ` Russell King - ARM Linux
2016-02-04 14:12 ` Russell King - ARM Linux
2016-02-04 14:32 ` Benjamin LaHaise
2016-02-04 14:32 ` Benjamin LaHaise
2016-02-04 14:39 ` Russell King - ARM Linux
2016-02-04 14:39 ` Russell King - ARM Linux
2016-02-04 16:01 ` Benjamin LaHaise
2016-02-04 16:01 ` Benjamin LaHaise
2016-02-04 16:17 ` Russell King - ARM Linux
2016-02-04 16:17 ` Russell King - ARM Linux
2016-02-04 16:27 ` Benjamin LaHaise
2016-02-04 16:27 ` Benjamin LaHaise
2016-02-04 16:47 ` Benjamin LaHaise
2016-02-04 16:47 ` Benjamin LaHaise
2016-02-04 18:48 ` Benjamin LaHaise
2016-02-04 18:48 ` Benjamin LaHaise
2016-01-15 2:24 ` Stephen Rothwell
2016-01-15 7:39 ` Christoph Hellwig
2016-01-15 9:23 ` Stephen Rothwell
2016-01-15 9:25 ` Christoph Hellwig
2016-01-15 15:18 ` Benjamin LaHaise
2016-01-15 22:55 ` Stephen Rothwell
2016-03-14 4:49 ` Stephen Rothwell
2016-03-14 17:08 ` Benjamin LaHaise
2016-03-14 20:41 ` Stephen Rothwell
2016-03-15 6:46 Stephen Rothwell
2016-03-15 6:46 ` Stephen Rothwell
2016-03-15 14:38 ` Andy Shevchenko
2016-03-15 16:42 ` Arnd Bergmann
2016-03-15 16:19 ` Sudip Mukherjee
2016-03-15 16:22 ` Benjamin LaHaise
2016-03-15 22:02 ` Arnd Bergmann
2016-03-16 11:12 ` Andy Shevchenko
2016-03-16 13:59 ` Arnd Bergmann
2016-03-16 14:07 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214E23B.9060608@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.