From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43973)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCBse-00017U-Sr
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:07:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCBsX-0004q0-IA
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:07:36 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51868 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VCBsX-0004pk-CX
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:07:29 -0400
Message-ID: <5214F3CC.1050509@suse.de>
Date: Wed, 21 Aug 2013 19:07:24 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com>
	<1377103396-24307-3-git-send-email-pbonzini@redhat.com>
	<20130821170358.GB12305@redhat.com> <5214F2B5.2080507@redhat.com>
In-Reply-To: <5214F2B5.2080507@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/3] pc: get rid of builtin pvpanic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>, armbru@redhat.com, qemu-devel@nongnu.org, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, hutao@cn.fujitsu.com, lcapitulino@redhat.com

Am 21.08.2013 19:02, schrieb Paolo Bonzini:
> Il 21/08/2013 19:03, Michael S. Tsirkin ha scritto:
>>>> It is a source of pain, and the previous patch anyway changed the
>>>> behavior of "-M pc-1.5" compared to the real 1.5.
>>>>
>>>> This also makes it clear that "-device pvpanic" is not enough:
>>>> it will not expose pvpanic in fw_cfg properly.
>>>>
>>>> No idea how to fix that.
>>>>
>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> That should be the first step. Make the device work properly.
>> We'll discuss compatibility when that is clear.
>>
>=20
> Actually these patches are not based on origin/master (my mistake)... I
> haven't tested, rebasing should be enough if "-device pvpanic" was
> tested properly for 1.6.

I haven't tested myself but I remember seeing patches moving fw_cfg
integration into the initfn/realizefn.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg