From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:33309 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253Ab3HURQI (ORCPT ); Wed, 21 Aug 2013 13:16:08 -0400 Message-ID: <5214F5D3.5060705@wwwdotorg.org> Date: Wed, 21 Aug 2013 11:16:03 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH V4] regulator: palmas: add support for external control of rails References: <1377082096-22296-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1377082096-22296-1-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Laxman Dewangan Cc: broonie@kernel.org, sameo@linux.intel.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, rob@landley.net, lee.jones@linaro.org, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, gg@slimlogic.co.uk, kishon@ti.com, j-keerthy@ti.com, ian.campbell@citrix.com List-ID: On 08/21/2013 04:48 AM, Laxman Dewangan wrote: > Palmas rails like LDOs, SMPSs, REGENs, SYSENs can be enable and disable > by register programming through I2C communication as well as it can be > enable/disable with the external control input ENABLE1, ENABLE2 and NSLEEP. > > Add support for configuring these rails to be controlled by external control > inputs. This is require to configure the rail's control register as well as > configuration of resource register. > > Provide the external input names through parameter "roof-floor". Updated the > DT binding document to details different value of the roof-floor. The binding change looks reasonable to me, so that part, Acked-by: Stephen Warren