From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCCJf-00074u-6K for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:35:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCCJW-0000ZH-C6 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:35:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52507 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCCJW-0000Z2-6C for qemu-devel@nongnu.org; Wed, 21 Aug 2013 13:35:22 -0400 Message-ID: <5214FA56.3030509@suse.de> Date: Wed, 21 Aug 2013 19:35:18 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1377103396-24307-1-git-send-email-pbonzini@redhat.com> <1377103396-24307-4-git-send-email-pbonzini@redhat.com> <20130821170120.GA12305@redhat.com> In-Reply-To: <20130821170120.GA12305@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Paolo Bonzini Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, hutao@cn.fujitsu.com, lcapitulino@redhat.com Am 21.08.2013 19:01, schrieb Michael S. Tsirkin: > On Wed, Aug 21, 2013 at 06:43:16PM +0200, Paolo Bonzini wrote: >> The pvpanic situation is already messed up enough. Let us give our >> libvirt friends an easy indication that we have untied our side. >> >> Not-yet-signed-off-by: Paolo Bonzini >> ... because we first have to determine how to expose the device's exis= tence >> in the ACPI tables or in fw_cfg. >> >> Signed-off-by: Paolo Bonzini >=20 > So it's isa-pvpanic meaning "I-am-sure-this-is-the-last-bug-pvpanic" >=20 > If we feel there's need to give libvirt a way to do > introspection into QEMU bugs, let's architect one. > Randomly renaming devices in the vain hope it's > the last major bug is not it. >=20 > NACK Seconded. While we shouldn't rule out renaming devices, doing so as a criteria for libvirt sounds utterly wrong. Paolo, you are right that a single "NACK" cannot be a criteria, but a single convincing justification by a random reviewer should be sufficient to reconsider. :) Adding some device property or obtaining the info via some existing query-* QMP command might be better alternatives. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg