From: Eric Blake <eblake@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Luiz Capitulino" <lcapitulino@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
anthony@codemonkey.ws, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore
Date: Wed, 21 Aug 2013 14:48:42 -0600 [thread overview]
Message-ID: <521527AA.4060200@redhat.com> (raw)
In-Reply-To: <521472D9.8060806@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
On 08/21/2013 01:57 AM, Laszlo Ersek wrote:
>>> I think we could consolidate everything in tests/.gitignore. But can we
>>> do it as an incremental patch? It's a very small cosmetic thing to respin
>>> the series and my pull request.
>>
>> Sure, it's not a bug.
>
> Is it OK if I submit a patch moving the test-* entries over to
> tests/.gitignore once Anthony applies this? (I'm offering because it's
> not clear to me who's planning to do it.)
Bikeshedding alert - I personally like having a single top-level
.gitignore for everything. We don't live in CVS days where you had to
have per-directory ignores, and having one file is easier to maintain
(in the future, it's easier to know WHICH .gitignore to add a new entry
to if there is only ONE .gitignore). I don't care enough to write the
patch myself, nor to care if you end up keeping the split .gitignore,
but if I did care, I'd be consolidating in the opposite direction (move
tests/.gitignore to the toplevel).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-21 20:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 16:10 [Qemu-devel] [PULL 00/11] QMP queue Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 01/11] Convert stderr message calling error_get_pretty() to error_report() Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 02/11] OptsVisitor: introduce basic list modes Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 03/11] OptsVisitor: introduce list modes for interval flattening Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 04/11] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 05/11] OptsVisitor: rebase opts_type_uint64() to parse_uint_full() Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 06/11] OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 07/11] OptsVisitor: don't try to flatten overlong integer ranges Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore Luiz Capitulino
2013-08-20 16:23 ` Andreas Färber
2013-08-20 18:39 ` Luiz Capitulino
2013-08-20 19:16 ` Andreas Färber
2013-08-21 7:57 ` Laszlo Ersek
2013-08-21 20:48 ` Eric Blake [this message]
2013-08-22 6:32 ` Markus Armbruster
2013-08-20 16:10 ` [Qemu-devel] [PULL 09/11] OptsVisitor: introduce unit tests, with test cases for range flattening Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 10/11] monitor: print the invalid char in error message Luiz Capitulino
2013-08-20 16:10 ` [Qemu-devel] [PULL 11/11] scripts/qapi.py: Avoid syntax not supported by Python 2.4 Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521527AA.4060200@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.