From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Subject: Re: [PATCH] drm/nouveau: avoid null deref on bad arguments to
	nouveau_vma_getmap
Date: Thu, 22 Aug 2013 09:12:40 +0200
Message-ID: <5215B9E8.5080108@canonical.com>
References: <1377130214-17522-1-git-send-email-imirkin@alum.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <1377130214-17522-1-git-send-email-imirkin@alum.mit.edu>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst <maarten.lankhorst@ubuntu.com>, Ben Skeggs <bskeggs@redhat.com>, =?UTF-8?B?UGFzaSBLw6Rya2vDpGluZW4=?= <pasik@iki.fi>
List-Id: nouveau.vger.kernel.org

T3AgMjItMDgtMTMgMDI6MTAsIElsaWEgTWlya2luIHNjaHJlZWY6Cj4gVGhlIGNvZGUgZXhwZWN0
cyBub24tVlJBTSBtZW0gbm9kZXMgdG8gaGF2ZSBhIHBhZ2VzIGxpc3QuIElmIHRoYXQncyBub3QK
PiBzZXQsIGl0IHdpbGwgZG8gYSBudWxsIGRlcmVmIGRvd24gdGhlIGxpbmUuIFdhcm4gb24gdGhh
dCBjb25kaXRpb24gYW5kCj4gcmV0dXJuIGFuIGVycm9yLgo+Cj4gU2VlIGh0dHBzOi8vYnVncy5m
cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTY0Nzc0Cj4KPiBSZXBvcnRlZC1ieTogUGFz
aSBLw6Rya2vDpGluZW4gPHBhc2lrQGlraS5maT4KPiBUZXN0ZWQtYnk6IFBhc2kgS8Okcmtrw6Rp
bmVuIDxwYXNpa0Bpa2kuZmk+Cj4gU2lnbmVkLW9mZi1ieTogSWxpYSBNaXJraW4gPGltaXJraW5A
YWx1bS5taXQuZWR1Pgo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyAzLjgrCj4gLS0t
Cj4KPiBJIGRvbid0IGV4YWN0bHkgdW5kZXJzdGFuZCB3aGF0J3MgZ29pbmcgb24sIGJ1dCB0aGlz
IGlzIGp1c3QgYQo+IHN0cmFpZ2h0Zm9yd2FyZCB3YXkgdG8gYXZvaWQgYSBudWxsIGRlcmVmIHRo
YXQgeW91IHNlZSBoYXBwZW5zIGluIHRoZQo+IGJ1Zy4gSSBoYXZlbid0IGZpZ3VyZWQgb3V0IHRo
ZSByb290IGNhdXNlIG9mIHRoaXMsIGJ1dCBpdCdzIGdldHRpbmcKPiB3ZWxsIGludG8gdGhlICJJ
IGhhdmUgbm8gaWRlYSBob3cgVFRNIHdvcmtzIiBzcGFjZS4gSG93ZXZlciB0aGlzIHNlZW1zCj4g
bGlrZSBhIGJpdCBvZiBkZWZlbnNpdmUgcHJvZ3JhbW1pbmcgLS0gbm91dmVhdV92bV9tYXBfc2cg
d2lsbCBwYXNzCj4gbm9kZS0+cGFnZXMgYXMgYSBsaXN0IGRvd24sIHdoaWNoIHdpbGwgYmUgZGVy
ZWZlcmVuY2VkIGJ5Cj4gbnZjMF92bV9tYXBfc2cuIFBlcmhhcHMgdGhlIG90aGVyIGFyZ3VtZW50
cyBzaG91bGQgbWFrZSB0aGF0Cj4gZGVyZWZlcmVuY2luZyBub3QgaGFwcGVuLCBidXQgaXQgZGVm
aW5pdGVseSB3YXMgaGFwcGVuaW5nIGhlcmUsIGFzIHlvdQo+IGNhbiBzZWUgaW4gdGhlIGJ1Zy4K
Pgo+IEJlbi9NYWFydGVuLCBJJ2xsIGxldCB5b3UganVkZ2Ugd2hldGhlciB0aGlzIGNoZWNrIGlz
IGFwcHJvcHJpYXRlLAo+IHNpbmNlIGxpa2UgSSBob3BlIEkgd2FzIGFibGUgdG8gY29udmV5IGFi
b3ZlLCBJJ20ganVzdCBub3QgcmVhbGx5IHN1cmUgOikKTm90IGl0IHJlYWxseSBpc24ndCBhcHBy
b3ByaWF0ZS4uCgpZb3UnZCBoYXZlIHRvIGNhbGwgY2FsbCBub3V2ZWF1X3ZtX21hcF9zZ190YWJs
ZSBpbnN0ZWFkLCB0aGUgb25seSBwbGFjZSB0aGF0IGRvZXNuJ3QgaGFuZGxlIHRoYXQgY29ycmVj
dGx5CmlzIHdoZXJlIGl0J3Mgbm90IGV4cGVjdGVkIHRvIGJlIGNhbGxlZC4KCkhlcmUsIGhhdmUg
YSBjb21wbGV0ZWx5IHVudGVzdGVkIHBhdGNoIHRvIGZpeCB0aGluZ3MuLi4KCmRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1
L2RybS9ub3V2ZWF1L25vdXZlYXVfZGlzcGxheS5jCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2
ZWF1L25vdXZlYXVfZGlzcGxheS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZl
YXVfZGlzcGxheS5jCkBAIC0xMzgsMTcgKzE0MywyNiBAQCBub3V2ZWF1X3VzZXJfZnJhbWVidWZm
ZXJfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiB7CiAJc3RydWN0IG5vdXZlYXVfZnJh
bWVidWZmZXIgKm5vdXZlYXVfZmI7CiAJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpnZW07CisJc3Ry
dWN0IG5vdXZlYXVfYm8gKm52Ym87CiAJaW50IHJldCA9IC1FTk9NRU07CiAKIAlnZW0gPSBkcm1f
Z2VtX29iamVjdF9sb29rdXAoZGV2LCBmaWxlX3ByaXYsIG1vZGVfY21kLT5oYW5kbGVzWzBdKTsK
IAlpZiAoIWdlbSkKIAkJcmV0dXJuIEVSUl9QVFIoLUVOT0VOVCk7CiAKKwludmJvID0gbm91dmVh
dV9nZW1fb2JqZWN0KGdlbSk7CisJaWYgKCEobnZiby0+dmFsaWRfZG9tYWlucyAmIE5PVVZFQVVf
R0VNX0RPTUFJTl9WUkFNKSkgeworCQludl93YXJuKG5vdXZlYXVfZHJtKGRldiksICJUcnlpbmcg
dG8gY3JlYXRlIGEgZmIgaW4gdnJhbSB3aXRoIgorCQkJIiB2YWxpZF9kb21haW5zPSUwOHhcbiIs
IG52Ym8tPnZhbGlkX2RvbWFpbnMpOworCQlyZXQgPSAtRUlOVkFMOworCQlnb3RvIGVycl91bnJl
ZjsKKwl9CisKIAlub3V2ZWF1X2ZiID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IG5vdXZlYXVfZnJh
bWVidWZmZXIpLCBHRlBfS0VSTkVMKTsKIAlpZiAoIW5vdXZlYXVfZmIpCiAJCWdvdG8gZXJyX3Vu
cmVmOwogCi0JcmV0ID0gbm91dmVhdV9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgbm91dmVhdV9mYiwg
bW9kZV9jbWQsIG5vdXZlYXVfZ2VtX29iamVjdChnZW0pKTsKKwlyZXQgPSBub3V2ZWF1X2ZyYW1l
YnVmZmVyX2luaXQoZGV2LCBub3V2ZWF1X2ZiLCBtb2RlX2NtZCwgbnZibyk7CiAJaWYgKHJldCkK
IAkJZ290byBlcnI7CiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl
dmVsCg==