Re: [Xenomai] xeno-regression-test returns SUCCESS when Xenomai not available

[Gernot Hillier <gernot.hillier@siemens.com>]

Hi!

Am 20.08.2013 23:49, schrieb Gilles Chanteperdrix:
> On 08/20/2013 08:15 PM, Gilles Chanteperdrix wrote:
>> On 08/20/2013 02:45 PM, Gernot Hillier wrote:
>>> Hi there!
>>>
>>> I'm currently working on an automatic test environment for Xenomai
>>> kernels. Sometimes, Xenomai integration into my kernel fails completely
>>> and I expected this to be detected in a xeno-regression-test run - however:
>>>
>>> root@localhost:~# xeno-regression-test && echo Worked.
>>> Started child 28231: /bin/bash
>>> /usr/lib/xenomai/testsuite/xeno-test-run-wrapper
>>> /usr/bin/xeno-regression-test
>>> ++ echo 0
>>> /usr/bin/xeno-regression-test: line 38: /proc/xenomai/latency: No such
>>> file or directory
>>> ++ :
>>> ++ /usr/lib/xenomai/testsuite/arith
>>> Xenomai: /dev/rtheap is missing
>>> (chardev, major=10 minor=254)
>>> Worked.
>>>
>>> Looking into xeno-test-run.c, I see that a dead script child is not
>>> causing an error exit of xeno-test-run in handle_script_child().
>>>
>>> Is there any special reason for that behaviour or could we just add a
>>> comparable EXIT_FAILURE branch as in handle_checked_child(), something
>>> like
>>
>> No, some piece is missing, but we can not exit right away, we have to
>> send a SIGTERM to all children, then return to the main loop which will
>> wait a bit, then send a SIGKILL if children are not answering, then
>> finally exit. And we have to take note somewhere of the child exit
>> status to call exit with the same exit status. Will send a patch shortly.
>>
>>
>
> Please try the following patch:

[...]

Seems to work perfectly for my use case. Thanks!!

-- 
Regards,
Gernot Hillier

Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux