From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.brezillon@overkiz.com (boris brezillon) Date: Thu, 22 Aug 2013 15:14:17 +0200 Subject: [RFC PATCH] phylib: mdio: handle register/unregister/register sequence In-Reply-To: <1377174836-10569-1-git-send-email-b.brezillon@overkiz.com> References: <1377174836-10569-1-git-send-email-b.brezillon@overkiz.com> Message-ID: <52160EA9.4060801@overkiz.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22/08/2013 14:33, Boris BREZILLON wrote: > Hello, > > This patch is a proposal to support the register/unregister/register > sequence on a given mdio bus. I forgot to ask, if this limitation was made on purpose ? In other terms: no one should ever try to register, unregister and register again a given mii_bus structure. > > I use the register/unregister/register sequence to add a fallback when the > of_mdiobus_register (this function calls mdiobus_register with phy_mask > set to ~0) does not register any phy device (because the device tree does > not define any phy). > In this case I call mdiobus_unregister and then call mdiobus_register with > a phy_mask set to 0 to trigger a full mdio bus scan. > > I'm not sure this is the right way to do it (this is why I added RFC in the > subject). > > Could someone help me figuring out what I should use to implement my fallback ? > > 1) use the register/unregister/register sequence > 2) reimplement the "for (i = 0; i < PHY_MAX_ADDR; i++)" mdiobus_scan loop > > Thanks. > > Best Regards, > Boris > > Boris BREZILLON (1): > phylib: mdio: handle register/unregister/register sequence > > drivers/net/phy/mdio_bus.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752847Ab3HVNiJ (ORCPT ); Thu, 22 Aug 2013 09:38:09 -0400 Received: from 10.mo3.mail-out.ovh.net ([87.98.165.232]:52434 "EHLO mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752256Ab3HVNiH (ORCPT ); Thu, 22 Aug 2013 09:38:07 -0400 X-Greylist: delayed 1500 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Aug 2013 09:38:07 EDT Message-ID: <52160EA9.4060801@overkiz.com> Date: Thu, 22 Aug 2013 15:14:17 +0200 From: boris brezillon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Boris BREZILLON CC: "David S. Miller" , Mark Brown , Nick Bowler , Greg Kroah-Hartman , Grant Likely , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Ovh-Mailout: 178.32.228.3 (mo3.mail-out.ovh.net) Subject: Re: [RFC PATCH] phylib: mdio: handle register/unregister/register sequence References: <1377174836-10569-1-git-send-email-b.brezillon@overkiz.com> In-Reply-To: <1377174836-10569-1-git-send-email-b.brezillon@overkiz.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 1056657064239396985 X-Ovh-Remote: 80.245.18.66 () X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -85 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeikedrgeefucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogetfedtuddqtdduucdludehmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -85 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeikedrgeefucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogetfedtuddqtdduucdludehmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2013 14:33, Boris BREZILLON wrote: > Hello, > > This patch is a proposal to support the register/unregister/register > sequence on a given mdio bus. I forgot to ask, if this limitation was made on purpose ? In other terms: no one should ever try to register, unregister and register again a given mii_bus structure. > > I use the register/unregister/register sequence to add a fallback when the > of_mdiobus_register (this function calls mdiobus_register with phy_mask > set to ~0) does not register any phy device (because the device tree does > not define any phy). > In this case I call mdiobus_unregister and then call mdiobus_register with > a phy_mask set to 0 to trigger a full mdio bus scan. > > I'm not sure this is the right way to do it (this is why I added RFC in the > subject). > > Could someone help me figuring out what I should use to implement my fallback ? > > 1) use the register/unregister/register sequence > 2) reimplement the "for (i = 0; i < PHY_MAX_ADDR; i++)" mdiobus_scan loop > > Thanks. > > Best Regards, > Boris > > Boris BREZILLON (1): > phylib: mdio: handle register/unregister/register sequence > > drivers/net/phy/mdio_bus.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris brezillon Subject: Re: [RFC PATCH] phylib: mdio: handle register/unregister/register sequence Date: Thu, 22 Aug 2013 15:14:17 +0200 Message-ID: <52160EA9.4060801@overkiz.com> References: <1377174836-10569-1-git-send-email-b.brezillon@overkiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: Nick Bowler , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Grant Likely , Mark Brown , netdev@vger.kernel.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org To: Boris BREZILLON Return-path: In-Reply-To: <1377174836-10569-1-git-send-email-b.brezillon@overkiz.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 22/08/2013 14:33, Boris BREZILLON wrote: > Hello, > > This patch is a proposal to support the register/unregister/register > sequence on a given mdio bus. I forgot to ask, if this limitation was made on purpose ? In other terms: no one should ever try to register, unregister and register again a given mii_bus structure. > > I use the register/unregister/register sequence to add a fallback when the > of_mdiobus_register (this function calls mdiobus_register with phy_mask > set to ~0) does not register any phy device (because the device tree does > not define any phy). > In this case I call mdiobus_unregister and then call mdiobus_register with > a phy_mask set to 0 to trigger a full mdio bus scan. > > I'm not sure this is the right way to do it (this is why I added RFC in the > subject). > > Could someone help me figuring out what I should use to implement my fallback ? > > 1) use the register/unregister/register sequence > 2) reimplement the "for (i = 0; i < PHY_MAX_ADDR; i++)" mdiobus_scan loop > > Thanks. > > Best Regards, > Boris > > Boris BREZILLON (1): > phylib: mdio: handle register/unregister/register sequence > > drivers/net/phy/mdio_bus.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >