From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCVxJ-0002M2-FE for qemu-devel@nongnu.org; Thu, 22 Aug 2013 10:33:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCVxD-0006oW-GV for qemu-devel@nongnu.org; Thu, 22 Aug 2013 10:33:45 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:58298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCVxD-0006oH-At for qemu-devel@nongnu.org; Thu, 22 Aug 2013 10:33:39 -0400 Message-ID: <5216212F.3060305@weilnetz.de> Date: Thu, 22 Aug 2013 16:33:19 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1377178116-28488-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1377178116-28488-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] win32: build fixes due to io_flush removal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel@nongnu.org Am 22.08.2013 15:28, schrieb Stefan Hajnoczi: > Stefan Weil noticed that the win32 build is broken with my io_flush changes > applied. The issues are simple build failures that should have been avoided by > test building Windows, which I didn't. > > To make amends I've set up a mingw cross-compiler and have fixed the build. > Sorry for the breakage. > > I can include this in my block pull request later today if you are happy with > the patches. > > Stefan Hajnoczi (2): > aio-win32: replace incorrect AioHandler->opaque usage with ->e > win32-aio: drop win32_aio_flush_cb() > > aio-win32.c | 4 ++-- > block/win32-aio.c | 10 +--------- > 2 files changed, 3 insertions(+), 11 deletions(-) > For both patches: Reviewed-by: Stefan Weil Hi Stefan, thank you for the fast fix. Please include it in your pull request. Regards, Stefan