From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] getty: add the ability to pass options to getty
Date: Thu, 22 Aug 2013 18:06:36 +0200 [thread overview]
Message-ID: <5216370C.5030804@mind.be> (raw)
In-Reply-To: <CAAXf6LUHMReVczEir1yXai13-jHm_zBkXQN=T-OvNdWL_BTy2Q@mail.gmail.com>
On 22/08/13 12:58, Thomas De Schampheleire wrote:
> There are now a number of getty-related config options in
> system/Config.in, but without any structure.
> When the getty port is empty, no action is taken.
> What about introducing a new bool option to determine if a getty needs
> to be started, with suboptions for port, baudrate, term, and
> user-configurable options?
> Something like:
>
> config BR2_TARGET_GENERIC_GETTY
> bool "Run a getty (login prompt) after boot"
>
> config BR2_TARGET_GENERIC_GETTY_PORT
> bool "tty port"
> depends on BR2_TARGET_GENERIC_GETTY
>
> choice
> prompt "baudrate"
> depends on BR2_TARGET_GENERIC_GETTY
>
> [baudrate options]
> endchoice
>
> config BR2_TARGET_GENERIC_GETTY_TERM
> bool "TERM environment variable"
> depends on BR2_TARGET_GENERIC_GETTY
>
> config BR2_TARGET_GENERIC_GETTY_OPTIONS
> string "other options to pass to getty"
> depends on BR2_TARGET_GENERIC_GETTY
Sounds like a good plan. Except that the sub-options should be wrapped
in a if...endif construct instead of repeating 'depends on'.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2013-08-22 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 5:12 [Buildroot] [PATCH] getty: add the ability to pass options to getty Assaf Inbal
2013-08-22 6:02 ` Arnout Vandecappelle
2013-08-22 7:28 ` Assaf Inbal
2013-08-22 11:01 ` Thomas De Schampheleire
2013-08-25 11:18 ` Assaf Inbal
2013-08-22 10:58 ` Thomas De Schampheleire
2013-08-22 16:06 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5216370C.5030804@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.