From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCYNz-00023D-Mm for qemu-devel@nongnu.org; Thu, 22 Aug 2013 13:09:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCYNt-0001FG-I2 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 13:09:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51258 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCYNt-0001Et-99 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 13:09:21 -0400 Message-ID: <521645BA.5020804@suse.de> Date: Thu, 22 Aug 2013 19:09:14 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1377190729-14008-1-git-send-email-rth@twiddle.net> <1377190729-14008-2-git-send-email-rth@twiddle.net> In-Reply-To: <1377190729-14008-2-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/18] qtest: Fix FMT_timeval vs time_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Anthony Liguori , qemu-devel@nongnu.org, aurelien@aurel32.net Am 22.08.2013 18:58, schrieb Richard Henderson: > Since FMT_timeval unconditionally uses %ld, cast tv_sec to long. >=20 > Signed-off-by: Richard Henderson > --- > qtest.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/qtest.c b/qtest.c > index 74f1842..4f6963b 100644 > --- a/qtest.c > +++ b/qtest.c > @@ -177,7 +177,7 @@ static void qtest_send_prefix(CharDriverState *chr) > =20 > qtest_get_time(&tv); > fprintf(qtest_log_fp, "[S +" FMT_timeval "] ", > - tv.tv_sec, (long) tv.tv_usec); > + (long) tv.tv_sec, (long) tv.tv_usec); > } > =20 > static void GCC_FMT_ATTR(2, 3) qtest_send(CharDriverState *chr, FMT_timeval is a file-local #define, so why not change that instead of all its users? I remember having a local patch around for one of the BSDs for MAX_TIME or something. We should really make less assumptions about sizes. Andreas > @@ -225,7 +225,7 @@ static void qtest_process_command(CharDriverState *= chr, gchar **words) > =20 > qtest_get_time(&tv); > fprintf(qtest_log_fp, "[R +" FMT_timeval "]", > - tv.tv_sec, (long) tv.tv_usec); > + (long) tv.tv_sec, (long) tv.tv_usec); > for (i =3D 0; words[i]; i++) { > fprintf(qtest_log_fp, " %s", words[i]); > } > @@ -485,7 +485,7 @@ static void qtest_event(void *opaque, int event) > qtest_opened =3D true; > if (qtest_log_fp) { > fprintf(qtest_log_fp, "[I " FMT_timeval "] OPENED\n", > - start_time.tv_sec, (long) start_time.tv_usec); > + (long) start_time.tv_sec, (long) start_time.tv_use= c); > } > break; > case CHR_EVENT_CLOSED: > @@ -494,7 +494,7 @@ static void qtest_event(void *opaque, int event) > qemu_timeval tv; > qtest_get_time(&tv); > fprintf(qtest_log_fp, "[I +" FMT_timeval "] CLOSED\n", > - tv.tv_sec, (long) tv.tv_usec); > + (long) tv.tv_sec, (long) tv.tv_usec); > } > break; > default: >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg