All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian Daudt" <csd@broadcom.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion
Date: Thu, 22 Aug 2013 10:46:53 -0700	[thread overview]
Message-ID: <52164E8D.7070404@broadcom.com> (raw)
In-Reply-To: <CAK9yfHwJjwsCq-oAjj3Cp9kFQhxnAfUfpwv9FzcDn-tGLav4xQ@mail.gmail.com>

On 13-08-21 11:07 PM, Sachin Kamat wrote:
> On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
>> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>> version.h header inclusion is not necessary as detected by
>>> versioncheck.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>>    drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>>>    1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>>> b/drivers/mmc/host/sdhci-bcm-kona.c
>>> index 87175f9..bca6d55 100644
>>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>>> @@ -24,7 +24,6 @@
>>>    #include <linux/of.h>
>>>    #include <linux/of_device.h>
>>>    #include <linux/of_gpio.h>
>>> -#include <linux/version.h>
>>>    #include <linux/mmc/slot-gpio.h>
>>>      #include "sdhci-pltfm.h"
>> Acked-by: Christian Daudt <csd@broadcom.com>
>>
>>   thanks,
>>     csd
>>
>>
> Ping Chris..
>
>
Hi Sachin,
  I can pull this one into bcm tree, as I already have other patches for 
that file in there. I'm also pulling in patch 3. Patch 2 was already 
covered by this commit which is already in my pull request to armsoc so 
I'll drop it:
Author: Markus Mayer <markus.mayer@linaro.org>
Date:   Wed Aug 7 15:39:59 2013 -0700

     mmc: sdhci-bcm-kona: make linker-section warning go away

     This change makes the following build warning go away:
     [...]
       LINK    vmlinux
       LD      vmlinux.o
       MODPOST vmlinux.o
     WARNING: modpost: Found 2 section mismatch(es).
     To see full details build your kernel with:
     'make CONFIG_DEBUG_SECTION_MISMATCH=y'

     Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
     Reviewed-by: Christian Daudt <csd@broadcom.com>
     Reviewed-by: Matt Porter <matt.porter@linaro.org>



  thanks,
    csd



  reply	other threads:[~2013-08-22 17:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08  6:11 [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
2013-07-08  6:11 ` [PATCH 2/3] mmc: sdhci-bcm-kona: Remove redundant use of_match_ptr Sachin Kamat
2013-07-19 20:31   ` Christian Daudt
2013-07-08  6:11 ` [PATCH 3/3] mmc: sdhci-bcm-kona: Staticize sdhci_bcm_kona_card_event Sachin Kamat
2013-07-19 20:31   ` Christian Daudt
2013-07-19 11:10 ` [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion Sachin Kamat
2013-07-19 20:31 ` Christian Daudt
2013-08-02  8:50   ` Sachin Kamat
2013-08-22  6:07   ` Sachin Kamat
2013-08-22 17:46     ` Christian Daudt [this message]
2013-08-23  8:44       ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52164E8D.7070404@broadcom.com \
    --to=csd@broadcom.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.