From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VCabX-0003kw-0E
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 15:31:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VCabO-0005qR-5B
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 15:31:34 -0400
Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:38608)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VCabN-0005qB-UZ
	for qemu-devel@nongnu.org; Thu, 22 Aug 2013 15:31:26 -0400
Received: by mail-we0-f182.google.com with SMTP id q59so2085299wes.41
	for <qemu-devel@nongnu.org>; Thu, 22 Aug 2013 12:31:25 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <521666E1.2020902@redhat.com>
Date: Thu, 22 Aug 2013 21:30:41 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1376307710-15641-1-git-send-email-alex@alex.org.uk>
	<20130822114513.GC27613@stefanha-thinkpad.redhat.com>
	<5216057B.7040602@redhat.com>
	<58C9F610-8966-4CD6-A2A7-82BA2B2BDD98@alex.org.uk>
In-Reply-To: <58C9F610-8966-4CD6-A2A7-82BA2B2BDD98@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip
 target volume creation)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Alexandre Derumier <aderumier@odiso.com>

Il 22/08/2013 20:03, Alex Bligh ha scritto:
> Paolo,
> 
> On 22 Aug 2013, at 13:35, Paolo Bonzini wrote:
> 
>> Also, this is the same as some HMP commands' "-n" option (live
>> snapshots, mirroring, backup) so I suggest to use that name.
> 
> You mean -n instead of -C? Sure I can do that, but is that
> something you feel strongly about? I am aware there are a number
> of people who have been using the patch with -C for some time.

I'll be fine if Stefan and Kevin override me, but yes, I think
consistency is important.  qemu-img has offline functionality equivalent
to block jobs, and it is useful to keep qemu-img subcommands as
consistent as possible between them and with the corresponding HMP
commands.  convert is the equivalent of the online mirroring block job.

Paolo