From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCiDi-0007qU-Lv for qemu-devel@nongnu.org; Thu, 22 Aug 2013 23:39:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCiDY-0000kD-1W for qemu-devel@nongnu.org; Thu, 22 Aug 2013 23:39:29 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:40487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCiDX-0000js-RL for qemu-devel@nongnu.org; Thu, 22 Aug 2013 23:39:19 -0400 Received: by mail-pa0-f52.google.com with SMTP id kq13so131331pab.39 for ; Thu, 22 Aug 2013 20:39:19 -0700 (PDT) Message-ID: <5216D960.8010406@ozlabs.ru> Date: Fri, 23 Aug 2013 13:39:12 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1376891726-26122-1-git-send-email-aik@ozlabs.ru> <1376891726-26122-3-git-send-email-aik@ozlabs.ru> <521223A4.2010205@suse.de> In-Reply-To: <521223A4.2010205@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 2/8] xics: add pre_save/post_load/cpu_setup dispatchers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , Paul Mackerras , qemu-ppc@nongnu.org, David Gibson On 08/19/2013 11:54 PM, Andreas Färber wrote: > Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy: >> The upcoming support of in-kernel XICS will redefine migration callbacks >> for both ICS and ICP so classes and callback pointers are added. >> >> This adds a cpu_setup callback to the XICS device class (as XICS-KVM >> will do it different) and xics_dispatch_cpu_setup(). This also moves >> the place where xics_dispatch_cpu_setup() is called a bit further to >> have VCPU initialized (required for XICS-KVM). >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> Changes: >> v3: >> * fixed local variables names >> --- >> hw/intc/xics.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++---- >> hw/ppc/spapr.c | 4 ++-- >> include/hw/ppc/xics.h | 46 +++++++++++++++++++++++++++++++++++++- >> 3 files changed, 104 insertions(+), 7 deletions(-) >> >> diff --git a/hw/intc/xics.c b/hw/intc/xics.c >> index 6b3c071..e3a957d 100644 >> --- a/hw/intc/xics.c >> +++ b/hw/intc/xics.c > [...] >> @@ -674,10 +724,12 @@ static Property xics_properties[] = { >> static void xics_class_init(ObjectClass *oc, void *data) >> { >> DeviceClass *dc = DEVICE_CLASS(oc); >> + XICSStateClass *k = XICS_CLASS(oc); >> >> dc->realize = xics_realize; >> dc->props = xics_properties; >> dc->reset = xics_reset; >> + k->cpu_setup = xics_cpu_setup; >> >> spapr_rtas_register("ibm,set-xive", rtas_set_xive); >> spapr_rtas_register("ibm,get-xive", rtas_get_xive); > > This hunk is fixed up in 4/8, please squash that bit here. Thanks for the review, fixed this. > Otherwise looks good. What exactly looks good? This patch only? The whole series? If it is the whole series, can I put Reviewed-By: Andreas into them before repost them all? I am asking because Alex Graf won't even look at them before I get them reviewed/acked/signed by some one less ignorant than me :) Thanks! -- Alexey