From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VClX6-0007uK-Rt
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 03:11:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VClX0-00080y-Fp
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 03:11:44 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=33785
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VClX0-00080j-7u
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 03:11:38 -0400
Message-ID: <52170B19.2080909@weilnetz.de>
Date: Fri, 23 Aug 2013 09:11:21 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1377241601-29105-1-git-send-email-christoffer.dall@linaro.org>
In-Reply-To: <1377241601-29105-1-git-send-email-christoffer.dall@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] migration: Fix debug print type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: linaro-kernel@lists.linaro.org, qemu-devel@nongnu.org, patches@linaro.org, kvmarm@lists.cs.columbia.edu

See my comment below.

Am 23.08.2013 09:06, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed.  Fix it.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
>  migration.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration.c b/migration.c
> index 1402fa7..0d8706f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -566,7 +566,7 @@ static void *migration_thread(void *opaque)
>          if (!qemu_file_rate_limit(s->file)) {
>              DPRINTF("iterate\n");
>              pending_size = qemu_savevm_state_pending(s->file, max_size);
> -            DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
> +            DPRINTF("pending size %llu max %llu\n", pending_size, max_size);

Please use PRIu64 for uint64_t.

>              if (pending_size && pending_size >= max_size) {
>                  qemu_savevm_state_iterate(s->file);
>              } else {