From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: allow to specify the base chain type
Date: Fri, 23 Aug 2013 10:39:05 +0300 [thread overview]
Message-ID: <52171199.5090700@linux.intel.com> (raw)
In-Reply-To: <1377185191-9961-1-git-send-email-pablo@netfilter.org>
Hi Pablo,
Nice extension. I just have small comments how we could improve the
command line:
> This patch allows you to specify the type of the base chain, eg.
>
> add table mangle
> add chain mangle OUTPUT { type route hook NF_INET_LOCAL_OUT 0; }
Instead of NF_INET_LOCAL_OUT could we get OUT? (not literally ;) )
IN, OUT, PRE-ROUTING, FORWARD, POST-ROUTING etc...
And depending on chain's family, nft would use the right value there
(IN: is NF_INET_LOCAL_IN for ipv4, NF_ARP_IN for arp, etc...)
It would also make command line easier and more readable.
One more debatable:
What about adding prio keyword? So it would be { type <string> hook
<string> prio <num> }
Or keeping both possibility <num> or prio <num>?
I can prepare a patch if you want,
Cheers,
Tomasz
next prev parent reply other threads:[~2013-08-23 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 15:26 [PATCH nft] src: allow to specify the base chain type Pablo Neira Ayuso
2013-08-23 7:39 ` Tomasz Bursztyka [this message]
2013-08-26 22:37 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52171199.5090700@linux.intel.com \
--to=tomasz.bursztyka@linux.intel.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.