From: Paolo Bonzini <pbonzini@redhat.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: lagarcia@br.ibm.com, mrhines@linux.vnet.ibm.com,
qemu-devel@nongnu.org, anthony@codemonkey.ws,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] savevm: wrong error set by ram_control_load_hook()
Date: Fri, 23 Aug 2013 12:12:12 +0200 [thread overview]
Message-ID: <5217357C.6050307@redhat.com> (raw)
In-Reply-To: <1377252185-25585-2-git-send-email-lilei@linux.vnet.ibm.com>
Il 23/08/2013 12:03, Lei Li ha scritto:
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
> savevm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 95a11f9..fb17a6f 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t flags)
>
> void ram_control_load_hook(QEMUFile *f, uint64_t flags)
> {
> - int ret = 0;
> + int ret = EINVAL;
This should be "-EINVAL".
Paolo
> if (f->ops->hook_ram_load) {
> ret = f->ops->hook_ram_load(f, f->opaque, flags);
>
next prev parent reply other threads:[~2013-08-23 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 10:03 [Qemu-devel] [PATCH 1/3] savevm: add comments for qemu_file_get_error() Lei Li
2013-08-23 10:03 ` [Qemu-devel] [PATCH 2/3] savevm: wrong error set by ram_control_load_hook() Lei Li
2013-08-23 10:12 ` Paolo Bonzini [this message]
2013-08-23 12:37 ` Lei Li
2013-08-23 10:03 ` [Qemu-devel] [PATCH 3/3] arch_init: right return for ram_save_iterate Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217357C.6050307@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=lagarcia@br.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.