From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <52174640.701@gmail.com> Date: Fri, 23 Aug 2013 04:23:44 -0700 From: Brian Norris MIME-Version: 1.0 To: Mark Brown Subject: Re: [PATCH V1 3/5] mtd: m25p80: add the quad-read support References: <1376885403-12156-1-git-send-email-b32955@freescale.com> <1376885403-12156-4-git-send-email-b32955@freescale.com> <20130822193453.GB10038@ld-irv-0074.broadcom.com> <20130822195559.GU26118@sirena.org.uk> In-Reply-To: <20130822195559.GU26118@sirena.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marek Vasut , devicetree@vger.kernel.org, b44548@freescale.com, dedekind1@gmail.com, b18965@freescale.com, linux-spi@vger.kernel.org, Huang Shijie , linux-mtd@lists.infradead.org, kernel@pengutronix.de, shawn.guo@linaro.org, dwmw2@infradead.org, wangyuhang , linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/22/2013 12:55 PM, Mark Brown wrote: > On Thu, Aug 22, 2013 at 12:34:53PM -0700, Brian Norris wrote: >> What you're really missing from device-tree (and the SPI subystem in >> general) is how to detect those SPI controllers which support dual and >> quad mode transfers, and how to communicate that a particular SPI >> transaction should be performed on 1 or 4 IO lines. We shouldn't have >> this just hacked in via assumptions. > > That bit does need to be fixed in this driver, yes. The SPI core now > has quad mode support. Where? Perhaps I'm missing the obvious, but I don't see SPI core quad support in linux-next or in Linus' tree. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: computersforpeace@gmail.com (Brian Norris) Date: Fri, 23 Aug 2013 04:23:44 -0700 Subject: [PATCH V1 3/5] mtd: m25p80: add the quad-read support In-Reply-To: <20130822195559.GU26118@sirena.org.uk> References: <1376885403-12156-1-git-send-email-b32955@freescale.com> <1376885403-12156-4-git-send-email-b32955@freescale.com> <20130822193453.GB10038@ld-irv-0074.broadcom.com> <20130822195559.GU26118@sirena.org.uk> Message-ID: <52174640.701@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/22/2013 12:55 PM, Mark Brown wrote: > On Thu, Aug 22, 2013 at 12:34:53PM -0700, Brian Norris wrote: >> What you're really missing from device-tree (and the SPI subystem in >> general) is how to detect those SPI controllers which support dual and >> quad mode transfers, and how to communicate that a particular SPI >> transaction should be performed on 1 or 4 IO lines. We shouldn't have >> this just hacked in via assumptions. > > That bit does need to be fixed in this driver, yes. The SPI core now > has quad mode support. Where? Perhaps I'm missing the obvious, but I don't see SPI core quad support in linux-next or in Linus' tree. Brian