Re: [PATCH v4 2/3] libata: Add support for SEND/RECEIVE FPDMA QUEUED

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 23-08-2013 13:40, Marc C wrote:

> From: Marc Carino <marc.ceeeee@gmail.com>

> Add support for the following ATA opcodes, which are present
> in SATA 3.1 and T13 ATA ACS-3:

>          SEND FPDMA QUEUED
>          RECEIVE FPDMA QUEUED

> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
[...]

> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 9062aa0..34ccadb 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2141,6 +2141,26 @@ static int ata_dev_config_ncq(struct ata_device *dev,
>   	else
>   		snprintf(desc, desc_sz, "NCQ (depth %d/%d)%s", hdepth,
>   			ddepth, aa_desc);
> +
> +	if ((ap->flags & ATA_FLAG_FPDMA_AUX) &&
> +		ata_id_has_ncq_send_and_recv(dev->id)) {

     Please start this line under the second ( above. It's the style preferred 
in libata as it's easier on the eyes.

> +		err_mask = ata_read_log_page(dev,
> +					     ATA_LOG_NCQ_SEND_RECV,
> +					     0,
> +					     ap->sector_buf,
> +					     1);
> +		if (err_mask) {
> +			ata_dev_dbg(dev,
> +				    "failed to get NCQ Send/Recv Log "
> +				    "Emask 0x%x\n",
> +				    err_mask);
> +		} else {
> +			dev->flags |= ATA_DFLAG_NCQ_SEND_RECV;
> +			memcpy(dev->ncq_send_recv_cmds, ap->sector_buf,
> +				ATA_LOG_NCQ_SEND_RECV_SIZE);
> +		}
> +	}
> +

WBR, Sergei