From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: [PATCH v6 3/3] mmc: dw_mmc: Set timeout to max upon resume Date: Fri, 23 Aug 2013 21:56:27 +0900 Message-ID: <52175BFB.2070405@samsung.com> References: <1377188348-3418-1-git-send-email-dianders@chromium.org> <1377188348-3418-4-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1377188348-3418-4-git-send-email-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Chris Ball , Seungwon Jeon , James Hogan , Grant Grundler , Alim Akhtar , Abhilash Kesavan , Tomasz Figa , Olof Johansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-mmc@vger.kernel.org Acked-by: Jaehoon Chung On 08/23/2013 01:19 AM, Doug Anderson wrote: > The TMOUT register is initted to 0xffffffff at probe time but isn't > initted after suspend/resume. Add an init of this value. > > No problems were observed without this (it will also get initted in > __dw_mci_start_request if there is data to send), but it makes the > register dump before and after suspend cleaner. > > Signed-off-by: Doug Anderson > Acked-by: Seungwon Jeon > Reviewed-by: Tomasz Figa > --- > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/mmc/host/dw_mmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index f6c7545..6a9a846 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2506,6 +2506,9 @@ int dw_mci_resume(struct dw_mci *host) > /* Restore the old value at FIFOTH register */ > mci_writel(host, FIFOTH, host->fifoth_val); > > + /* Put in max timeout */ > + mci_writel(host, TMOUT, 0xFFFFFFFF); > + > mci_writel(host, RINTSTS, 0xFFFFFFFF); > mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER | > SDMMC_INT_TXDR | SDMMC_INT_RXDR | >