From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCsDA-0005nu-4Q for qemu-devel@nongnu.org; Fri, 23 Aug 2013 10:19:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCsD4-00033D-Ub for qemu-devel@nongnu.org; Fri, 23 Aug 2013 10:19:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47246 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCsD4-00032r-O8 for qemu-devel@nongnu.org; Fri, 23 Aug 2013 10:19:30 -0400 Message-ID: <52176F6F.9020307@suse.de> Date: Fri, 23 Aug 2013 16:19:27 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1377265136-8559-1-git-send-email-peter.maydell@linaro.org> <1377265136-8559-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1377265136-8559-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] virtio: Remove unnecessary OBJECT casts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, qemu-devel@nongnu.org, Alexander Graf , Anthony Liguori , Cornelia Huck , =?ISO-8859-15?Q?KONRAD_Fr=E9d=E9ric?= Am 23.08.2013 15:38, schrieb Peter Maydell: > There's no need to cast the first argument of object_initialize > to Object, and it would defeat the ability to check that the > pointer being passed is to a type large enough for the object. > Remove these unnecessary casts. >=20 > Signed-off-by: Peter Maydell > --- > hw/s390x/s390-virtio-bus.c | 12 ++++++------ > hw/s390x/virtio-ccw.c | 14 +++++++------- > hw/virtio/virtio-pci.c | 16 ++++++++-------- > 3 files changed, 21 insertions(+), 21 deletions(-) Reviewed-by: Andreas F=E4rber Depending on how we proceed we may want to tweak the commit message. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg