From: "Andreas Färber" <afaerber@suse.de>
To: Brad Smith <brad@comstyle.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: Eliminate __packed redefined warning
Date: Fri, 23 Aug 2013 18:36:41 +0200 [thread overview]
Message-ID: <52178F99.20300@suse.de> (raw)
In-Reply-To: <20130823162825.GB22101@rox.home.comstyle.com>
Am 23.08.2013 18:28, schrieb Brad Smith:
> This eliminates a warning about __packed being redefined as exposed by the
> vmxnet3 code. __packed is not used anywhere in the vmxnet3 code.
>
> CC hw/net/vmxnet3.o
> In file included from hw/net/vmxnet3.c:29:
> hw/net/vmxnet3.h:37:1: warning: "__packed" redefined
> In file included from /usr/include/stdlib.h:38,
> from /buildbot-qemu/default_openbsd_current/build/include/qemu-common.h:26,
> from /buildbot-qemu/default_openbsd_current/build/include/hw/hw.h:5,
> from hw/net/vmxnet3.c:18:
> /usr/include/sys/cdefs.h:209:1: warning: this is the location of the previous definition
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
CC'ing Stefan as net maintainer.
Andreas
>
> diff --git a/hw/net/vmxnet3.h b/hw/net/vmxnet3.h
> index 4eae7c7..f987d71 100644
> --- a/hw/net/vmxnet3.h
> +++ b/hw/net/vmxnet3.h
> @@ -34,7 +34,6 @@
> #define __le16 uint16_t
> #define __le32 uint32_t
> #define __le64 uint64_t
> -#define __packed QEMU_PACKED
>
> #if defined(HOST_WORDS_BIGENDIAN)
> #define __BIG_ENDIAN_BITFIELD
> @@ -749,7 +748,6 @@ struct Vmxnet3_DriverShared {
> #undef __le16
> #undef __le32
> #undef __le64
> -#undef __packed
> #if defined(HOST_WORDS_BIGENDIAN)
> #undef __BIG_ENDIAN_BITFIELD
> #endif
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-23 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 16:28 [Qemu-devel] [PATCH] vmxnet3: Eliminate __packed redefined warning Brad Smith
2013-08-23 16:36 ` Andreas Färber [this message]
2013-08-26 8:26 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52178F99.20300@suse.de \
--to=afaerber@suse.de \
--cc=brad@comstyle.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.